[SVCS-566]Update MFR Loading Spinner To Follow OSF Style Guide #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslzchen
requested changes
May 3, 2018
There was a problem hiding this comment.
The code hasn't been updated for more than a month. Can you rebase to the latest MFR, reset/refactor the commits into one or two, and test a few extensions locally? A few screenshots are recommended in the PR/ticket so I know what to and not to expect. Back to you, thanks! 🔥
NyanHelsing
force-pushed
the
update-mfr-loader
branch
from
d8e5d45 to
c20b137
Compare
cslzchen
changed the title
Users prefer the pulsing ball to the COS-logo spinner. Please see https://centerforopenscience.github.io/osf-style/style.html#loader This doesn't really affect the iframe content served by MFR. Instead, this changes happens in the mfr.js and mfr.css files loaded from MFR by the site hosting the iframe. The fact that mfr.js is included in most iframe content templates is a development artifact and will be eventually removed.
[skip ci] Three commits that has been squashed: Anchor loader pulsar to avoid jumping around * Hide iframe until load message is received. * Use absolute positioning for loader. Fix iframe hiding to avoid breaking stl, pdb, and images * Switch to using `opacity: 0.0` instead of `display: none` to hide iframes that are still being built. Use of `display: none` was causing OpenGL-based renderers (pdb and 3D-object) to fail, and was disabling image zoom for large images. Only style the mfr loader'
cslzchen
force-pushed
the
update-mfr-loader
branch
from
c20b137 to
c2df461
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/SVCS-566
Purpose
Get rid of old loading spinner
Changes
replaced old spinner with new pure css osf-style spinner
Side effects
None
QA Notes
#Deployment Notes