[ENG-8423] add ruff support #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslzchen
reviewed
Aug 12, 2025
There was a problem hiding this comment.
Looks good with one question which is initially asked by @felliott .
There are minor differences between WB (left) and MFR (right) for the rules, wondering if we should make them the same. Or is there any special considerations for the discrepancy?
| @@ -1,4 +1,4 @@ | |||
| # This file is automatically @generated by Poetry 2.1.3 and should not be changed by hand. | |||
| # This file is automatically @generated by Poetry 2.1.2 and should not be changed by hand. | |||
There was a problem hiding this comment.
- it looks like some configurations in WB fail the process for now on
ruff format .command run
and it looks we need to update it for WB
- the following one constraints added previously "E501", "E265", "E301", "E302", "F403", "E731", "B904", "B905" (I don't recall but maybe I added it previously to make it possible to run test suit without linter blocking, for now it goes ok without that constraints) , I removed it to keep it same
felliott
force-pushed
the
feature/ENG---8423
branch
from
298dd25 to
5fd07dc
Compare
felliott
merged commit a080e58
into
CenterForOpenScience:feature/buff-worms
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-8423
Purpose
add ruff support
Changes
added dependencies and configurations in poetry.lock and .toml files
(
more detailed PR here
#395
)
Side effects
created the PR from the following one #399
to keep it changings so please merge 399 previously
QA Notes
Deployment Notes