Skip to content

Commit

Permalink
Fix typo and update comment
Browse files Browse the repository at this point in the history
  • Loading branch information
cslzchen committed Jan 9, 2025
1 parent a61659f commit d587741
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion api/base/filters.py
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,9 @@ def parse_query_params(self, query_params):
field_name: self._parse_date_param(field, source_field_name, op, value),
})
elif not isinstance(value, int) and source_field_name in ['_id', 'guid._id']:
# TODO: this is broken since value can be a multi-value str separated by comma
# TODO: this is broken since value can be a multi-value str separated by comma; in addition,
# as for a single-versioned-guid value, the filter is `or` but we need `and`; this will
# be fixed in [ENG-6878](https://openscience.atlassian.net/browse/ENG-6878).
base_guid, version = Guid.split_guid(value)
if base_guid is None and version is None:
raise InvalidFilterValue(
Expand Down
2 changes: 1 addition & 1 deletion api/guids/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def get_serializer_class(self):
return None

def get_object(self):
base_guid_str, _ = Guid.split_guid(self.kwargs['guid'])
base_guid_str, _ = Guid.split_guid(self.kwargs['guids'])
return get_object_or_error(
Guid,
base_guid_str,
Expand Down

0 comments on commit d587741

Please sign in to comment.