[ENG-6801] Preprint _id caching #10881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cslzchen
requested changes
Jan 3, 2025
There was a problem hiding this comment.
Our code base is confusing ... most newer pieces use Django's built-in @cached_property while this old Guid piece still uses our own implementation of @cached_property ... and I also found another ancient flask model using @cached_property fromwerkzeug ...
Can you take a look at if django.utils.functional.cached_property is worth switching and if there is any compatibility concerns? @mfraezz will be back on Monday so we can ask for his input too.
Ostap-Zherebetskyi
force-pushed
the
feature/_id_cache
branch
from
89f55e8 to
a5440c0
Compare
Ostap-Zherebetskyi
force-pushed
the
feature/_id_cache
branch
from
8cfd184 to
42e7907
Compare
cslzchen
requested changes
Jan 7, 2025
cslzchen
approved these changes
Jan 7, 2025
|
Cherry-picked into #10892 and will merge there |
mfraezz
reviewed
Jan 7, 2025
|
Merged in 7b16120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Make
_ida cached propertyChanges
see diff
QA Notes
N/A
Documentation
N/A
Side Effects
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-6801