-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-6945] Added draft registrations page in admin app #10962
[ENG-6945] Added draft registrations page in admin app #10962
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question about a couple of labels, otherwise looks great. Oh, and also Product is wondering if you could put in total storage usage into the detail page.
<table class="table table-striped table-hover table-responsive"> | ||
<thead> | ||
<tr> | ||
<th>GUID</th> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here with id
</thead> | ||
<tbody> | ||
<tr> | ||
<td>Guid</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since draft registrations don't have a guid, would it make more sense to just call this id
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I left it because for Product it's guid and didn't want to confuse them, will rename it
I'll try but this functionality can be reused only if model inherits from Node that is not our case (drafts don't have guid, custom_storage_usage_limit_public, custom_storage_usage_limit_private fields), thus cannot be sure it's possible |
@brianjgeiger I managed to implement it. As expected the issue was that Drafts don't inherit from AbstractNode, but files have relationship to AbstractNode via target_content_type thus added additional conditions |
29dd2aa
into
CenterForOpenScience:feature/b-and-i-25-01
Purpose
User should be able to view users' draft registrations by their guid by the requirement:
Changes
Search by user's guid:
![image](https://private-user-images.githubusercontent.com/194797550/410402352-f391e7df-531e-4792-9257-a2e2e6ae9e65.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NjM1MTEsIm5iZiI6MTczOTQ2MzIxMSwicGF0aCI6Ii8xOTQ3OTc1NTAvNDEwNDAyMzUyLWYzOTFlN2RmLTUzMWUtNDc5Mi05MjU3LWEyZTJlNmFlOWU2NS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QxNjEzMzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xOTI4Y2E5NGMwZTFhZmEzNjhkYzlhM2JhZDk1YmEyMDYzMzkzYWYwMzcwY2I4MmRiYzVkYzVhZjBhNGI2NTc4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.hmr2aBX-lKC1TCDbZTw_YZwqrmz2-Td60F59PU26SAk)
List of his draft registrations:
![Screenshot from 2025-02-06 11-48-42](https://private-user-images.githubusercontent.com/194797550/410401617-503b00a1-219a-4dcb-90f4-0e11a32dc4b6.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NjM1MTEsIm5iZiI6MTczOTQ2MzIxMSwicGF0aCI6Ii8xOTQ3OTc1NTAvNDEwNDAxNjE3LTUwM2IwMGExLTIxOWEtNGRjYi05MGY0LTBlMTFhMzJkYzRiNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QxNjEzMzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mM2RjNzU2MzVhMWQyYjYwODE1MDEzMDIwOWRkYmYyN2Q1YmNmYTNjNzljY2I1YWUwNmE2ZmRiOGZlNGYxMmQ1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.Ipz7tEBrFIF3hQZuKLFITiAmXYwsp3V1vAIPvAEQ0SY)
Specific draft registration page:
![image](https://private-user-images.githubusercontent.com/194797550/410516763-352a7408-42cb-4e9c-bffc-f7f83c542a9d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0NjM1MTEsIm5iZiI6MTczOTQ2MzIxMSwicGF0aCI6Ii8xOTQ3OTc1NTAvNDEwNTE2NzYzLTM1MmE3NDA4LTQyY2ItNGU5Yy1iZmZjLWY3ZjgzYzU0MmE5ZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QxNjEzMzFaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iODMyOGYxY2NkOWU0MzU1NzVjYTY3OWRiMjIxNjVlMzI3ZGE5MTY0YTEyZDM5Mjk2ZWNjOTIxYjEwMjVlYTI5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.tFpEPiFykCTtdId-RuZHGpcRcUdCwDU5QlNOwaC9AwE)
Notes
Ticket
https://openscience.atlassian.net/browse/ENG-6945