[ENG-8828] Allow for the complete removal of a preprint (in initial state) from the database #11330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlius
reviewed
Oct 23, 2025
| - The base Guid points to the latest published version | ||
| - We only delete the specific broken draft version, not the entire preprint lineage | ||
| """ | ||
| permission_required = ('osf.delete_preprint',) |
There was a problem hiding this comment.
Is osf.delete_preprint only available to OSF Admins? If not, we might want something that's a bit more restrictive.
There was a problem hiding this comment.
No, osf.delete_preprint is django-generated permission, I copied it from the PreprintDeleteView. As far as I know there's no django-generated permission to check if user is admin, so I'll add explicit check inside of the view
|
tests passed on my local branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
add hard-delete draft preprint versions functionality to admin
Changes
QA Notes
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-8828