Spelling #11379

jsoref · 2025-10-17T17:07:19Z

I can rebase to master if requested.

Purpose

This PR corrects misspellings identified by the check-spelling action

The misspellings have been reported at https://github.com/jsoref/osf.io/actions/runs/18599108247/attempts/1#summary-53032928103

The action reports that the changes in this PR would make it mostly happy: https://github.com/jsoref/osf.io/actions/runs/18599109509/attempts/1#summary-53032931263

Changes

Spelling fixes

QA Notes

Please make verification statements inspired by your code and what your code touches.

Verify
Verify

What are the areas of risk?

Any concerns/considerations/questions that development raised?

Documentation

Side Effects

Certainly (there are approximately 330 sets of changes)

Ticket

Signed-off-by: Josh Soref <[email protected]>

jsoref · 2025-10-17T17:14:09Z

website/static/css/pages/wiki-page.css

@@ -28,7 +28,7 @@
 .wiki-sidenav h4 {
    margin-top:20px;
    margin-bottom: 0;
-    font-weigth: normal;
+    font-weight: normal;


website/static/dictionaries/en_US/en_US.dic

jsoref · 2025-10-17T17:18:02Z

.docker-compose.gv.env

 SESSION_COOKIE_HTTPONLY=true
 SESSION_COOKIE_SAMESITE=Lax
-OSF_SENSITIVE_DATA_SECRET="TrainglesAre5Squares"
+OSF_SENSITIVE_DATA_SECRET="TrianglesAre5Squares"


I'm assuming no one cares.

jsoref · 2025-10-17T17:19:08Z

PULL_REQUEST_TEMPLATE.md

 ## Ticket

-<!-- Link to JIRA ticket, if applicable e.g. https://openscience.atlassian.net/browse/OSF-1234 -->
+<!-- Link to Jira ticket, if applicable e.g. https://openscience.atlassian.net/browse/OSF-1234 -->


jsoref · 2025-10-17T17:19:12Z

README-docker-compose.md


 1. Install the Docker Client
-  - OSX: https://www.docker.com/products/docker#/mac
+  - macOS: https://www.docker.com/products/docker#/mac


jsoref · 2025-10-17T18:16:44Z

api_tests/identifiers/management_commands/test_sync_dois.py

-...ers/managment_commands/test_sync_dois.py +...ers/management_commands/test_sync_dois.py

jsoref · 2025-10-17T18:17:04Z

api_tests/registrations/views/test_registration_callbacks.py

-...ons/views/test_regisatration_callbacks.py +...ons/views/test_registration_callbacks.py

jsoref · 2025-10-17T18:17:24Z

api_tests/registrations/views/test_registrations_children_list.py

-...iews/test_registrations_childrens_list.py +...iews/test_registrations_children_list.py

jsoref · 2025-10-17T18:17:43Z

tests/test_project_contributor_views.py

-tests/test_project_contibutor_views.py +tests/test_project_contributor_views.py

jsoref · 2025-10-17T18:18:08Z

website/static/tmp/American_Economic_Review_Registration.txt

-...merican_Economic_Review_Resgistration.txt +...merican_Economic_Review_Registration.txt

futa-ikeda · 2025-10-21T18:01:13Z

I'll be reviewing this PR either today or tomorrow, depending on availability. For both of these PRs, I will check with others and update the target branch accordingly if that's ok with you. Sorry for the delay in getting back to you, and thank you so much for your contributions!

futa-ikeda

This took a little longer to get through than expected! Thank you for all the work here! I think the biggest change that gave me pause was one of the URL patterns that we use has a typo in it (external_login_comfirm_email using "coMfirm" with an "M"). To make sure we don't mess up the routing for any existing links with that typo, I would err on the side of caution and avoid replacing the route, and just add a new route with the correct spelling that does the same thing. I'll leave a comment with the suggested change. There's another wording change regarding an email that goes out to deleted users that I want to run past our product team and make sure they are ok with that update.

api/base/serializers.py

futa-ikeda · 2025-10-24T14:19:23Z

api/nodes/views.py

            operation['source_field_name'] = '_path'
        # NOTE: This is potentially fragile, if we ever add filtering on provider
-        # we're going to have to get a bit tricky. get_default_queryset should ramain filtering on BaseFileNode, for now
+        # we're going to have to get a bit tricky. get_default_queryset should retain filtering on BaseFileNode, for now


I believe this should be "remain" in this case?

futa-ikeda · 2025-10-24T14:44:32Z

api/users/urls.py

 urlpatterns = [
    re_path(r'^reset_password/$', views.ResetPassword.as_view(), name=views.ResetPassword.view_name),
-    re_path(r'^external_login_comfirm_email/$', views.ExternalLoginConfirmEmailView.as_view(), name=views.ExternalLoginConfirmEmailView.view_name),
+    re_path(r'^external_login_confirm_email/$', views.ExternalLoginConfirmEmailView.as_view(), name=views.ExternalLoginConfirmEmailView.view_name),


Hmmm, yea, this may cause some existing links to break. My hunch is to leave the old misspelled path, and add the correct spelling path instead.

futa-ikeda · 2025-10-24T14:46:48Z

api_tests/base/test_filters.py

-        filter_str = 'fitler[name]'
+        filter_str = 'filter[name]'
        match = self.filter_regex.match(filter_str)
        assert not match

    def test_single_field_non_alphanumeric_character(self):
-        filter_str = 'fitler[<name>]'
+        filter_str = 'filter[<name>]'


I agree that this is a notable change, but now this should actually be testing what we want it to test, so should be an improvement.

futa-ikeda · 2025-10-24T14:48:34Z

api_tests/nodes/views/test_node_children_list.py


    def test_bulk_creates_children_and_sanitizes_html_logged_in_owner(
            self, app, user, project, url):
-        title = '<em>Reasoning</em> <strong>Aboot Projects</strong>'


This one gave me a chuckle 😄

As a (relatively new) Canadian, things like this definitely give me a chuckle.

futa-ikeda · 2025-10-24T15:27:44Z

osf/models/collection_submission.py

                user=contributor,
                submitter=user,
-                is_initator=self.creator == contributor,
+                is_initiator=self.creator == contributor,


Just leaving myself a reminder here: if /website/templates/emails/collection_submission_submitted.html.mako is updated with this change, I think we are ok

futa-ikeda · 2025-10-24T15:30:24Z

osf/models/nodelog.py


    RESOURCE_ADDED = 'resource_identifier_added'
-    RESOURCE_UPDATED = 'resource_identifier_udpated'
+    RESOURCE_UPDATED = 'resource_identifier_updated'


Comment for self: potentially notable change here as this is likely used in the frontend. Check front-end repo to make sure this isn't being used with the typo included

Looks like we should be ok with this corrected spelling https://github.com/CenterForOpenScience/angular-osf/blob/main/src/assets/i18n/en.json#L3052

futa-ikeda · 2025-10-24T19:31:54Z

scripts/populate_institutions.py

                '_id': 'cornell',
                'name': 'Cornell University',
-                'description': 'Supported by the Cornell Research Data Management Service Group and the Cornell University Library. The OSF service may not be used to store or transfer personally identifiable, confidential/restricted, HIPPA-regulated or any other controlled unclassified information. Learn more at <a href="https://data.research.cornell.edu">https://data.research.cornell.edu</a> | <a href="mailto:[email protected]">[email protected]</a>.',
+                'description': 'Supported by the Cornell Research Data Management Service Group and the Cornell University Library. The OSF service may not be used to store or transfer personally identifiable, confidential/restricted, HIPAA-regulated or any other controlled unclassified information. Learn more at <a href="https://data.research.cornell.edu">https://data.research.cornell.edu</a> | <a href="mailto:[email protected]">[email protected]</a>.',


Should be fine to update these, as these descriptions are separate from the ones we should be using in production. These are scripts used to populate institutions during local development.

futa-ikeda · 2025-10-24T22:32:34Z

website/templates/emails/collection_submission_submitted.html.mako

@@ -8,7 +8,7 @@
        Hello ${user.fullname},<br>
        <br>
        <p>
-            % if is_initator:
+            % if is_initiator:


Note to myself (and any other reviewer), this is updated in `osf/models/collection_submission.py as well

futa-ikeda · 2025-10-24T22:40:15Z

website/templates/emails/request_deactivation_complete.html.mako

-    Your OSF account has been deactivated. You will not show up in search, nor will a profile be visible for you.
+    Your OSF account has been deactivated. You will not show up in search, nor will your profile be visible.


Will bring this up with our Product team to make sure this language change is ok with them

api/users/urls.py

Co-authored-by: futa-ikeda <[email protected]>

jsoref added 30 commits October 17, 2025 13:15

spelling: database

8fd7d30

Signed-off-by: Josh Soref <[email protected]>

spelling: datacite

c28786f

Signed-off-by: Josh Soref <[email protected]>

spelling: decode

d9f3752

Signed-off-by: Josh Soref <[email protected]>

spelling: deleted

1e24469

Signed-off-by: Josh Soref <[email protected]>

spelling: delimiters

1a141cc

Signed-off-by: Josh Soref <[email protected]>

spelling: descendents

efd8568

Signed-off-by: Josh Soref <[email protected]>

spelling: description

469dbb1

Signed-off-by: Josh Soref <[email protected]>

spelling: desynchronized

c1f66c0

Signed-off-by: Josh Soref <[email protected]>

spelling: development

fc8fb73

Signed-off-by: Josh Soref <[email protected]>

spelling: dictionaries

e0c4737

Signed-off-by: Josh Soref <[email protected]>

spelling: disconnect

150f087

Signed-off-by: Josh Soref <[email protected]>

spelling: distinguishing

70121e1

Signed-off-by: Josh Soref <[email protected]>

spelling: draggable

cbb8406

Signed-off-by: Josh Soref <[email protected]>

spelling: each

809cb6e

Signed-off-by: Josh Soref <[email protected]>

spelling: educational

acd99a2

Signed-off-by: Josh Soref <[email protected]>

spelling: effects tested

7bbd981

Signed-off-by: Josh Soref <[email protected]>

spelling: efficient

0b31441

Signed-off-by: Josh Soref <[email protected]>

spelling: elsewhere

cd27e25

Signed-off-by: Josh Soref <[email protected]>

spelling: embargoed

d39cdb1

Signed-off-by: Josh Soref <[email protected]>

spelling: endpoint

d9438f5

Signed-off-by: Josh Soref <[email protected]>

spelling: engagement

3fdaa7e

Signed-off-by: Josh Soref <[email protected]>

spelling: enqueues

106d7a6

Signed-off-by: Josh Soref <[email protected]>

spelling: entire

20122c0

Signed-off-by: Josh Soref <[email protected]>

spelling: entries

7288102

Signed-off-by: Josh Soref <[email protected]>

spelling: error

2376c83

Signed-off-by: Josh Soref <[email protected]>

spelling: exactly

fda8480

Signed-off-by: Josh Soref <[email protected]>

spelling: exceeds

5966c95

Signed-off-by: Josh Soref <[email protected]>

spelling: existence

bf9cb18

Signed-off-by: Josh Soref <[email protected]>

spelling: existing

5fd22d4

Signed-off-by: Josh Soref <[email protected]>

spelling: expected

4126f9e

Signed-off-by: Josh Soref <[email protected]>

jsoref added 23 commits October 17, 2025 14:11

spelling: unnecessary

dfa20d3

Signed-off-by: Josh Soref <[email protected]>

spelling: unstructured

ed3c504

Signed-off-by: Josh Soref <[email protected]>

spelling: unverified

9650a76

Signed-off-by: Josh Soref <[email protected]>

spelling: updated

3683482

Signed-off-by: Josh Soref <[email protected]>

spelling: user

43f18a9

Signed-off-by: Josh Soref <[email protected]>

spelling: username

574b173

Signed-off-by: Josh Soref <[email protected]>

spelling: users

115969c

Signed-off-by: Josh Soref <[email protected]>

spelling: verifications

ca8fec7

Signed-off-by: Josh Soref <[email protected]>

spelling: version

da3be86

Signed-off-by: Josh Soref <[email protected]>

spelling: versions

2a1cb99

Signed-off-by: Josh Soref <[email protected]>

spelling: view

0d6b87d

Signed-off-by: Josh Soref <[email protected]>

spelling: waffle

5212498

Signed-off-by: Josh Soref <[email protected]>

spelling: waterbutler

f2889e3

Signed-off-by: Josh Soref <[email protected]>

spelling: website

3356a20

Signed-off-by: Josh Soref <[email protected]>

spelling: weight

9aa7aec

Signed-off-by: Josh Soref <[email protected]>

spelling: when

e5bb477

Signed-off-by: Josh Soref <[email protected]>

spelling: whether or not

88fd7c3

Signed-off-by: Josh Soref <[email protected]>

spelling: whether

ff1d56a

Signed-off-by: Josh Soref <[email protected]>

spelling: which

cf3714d

Signed-off-by: Josh Soref <[email protected]>

spelling: with

4dfd8f3

Signed-off-by: Josh Soref <[email protected]>

spelling: withdrawn

db88a88

Signed-off-by: Josh Soref <[email protected]>

spelling: won't

f9ad721

Signed-off-by: Josh Soref <[email protected]>

spelling: your profile be visible

e6a6645

Signed-off-by: Josh Soref <[email protected]>

jsoref commented Oct 17, 2025

View reviewed changes

jsoref force-pushed the spelling branch from c055a11 to e6a6645 Compare October 17, 2025 18:19

jsoref marked this pull request as ready for review October 17, 2025 18:20

futa-ikeda suggested changes Oct 24, 2025

View reviewed changes

futa-ikeda reviewed Oct 24, 2025

View reviewed changes

api/users/urls.py Show resolved Hide resolved

Apply suggestions from code review

84cfbd0

Co-authored-by: futa-ikeda <[email protected]>

		Your OSF account has been deactivated. You will not show up in search, nor will a profile be visible for you.
		Your OSF account has been deactivated. You will not show up in search, nor will your profile be visible.

Spelling #11379

Are you sure you want to change the base?

Spelling #11379

Uh oh!

Conversation

jsoref commented Oct 17, 2025

Purpose

Changes

QA Notes

Documentation

Side Effects

Ticket

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

futa-ikeda commented Oct 21, 2025

Uh oh!

futa-ikeda left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants