Skip to content

[ENG-9622] Contributor claim link temporarily returns “Not Found” before becoming accessible and showing “User has already been claimed.” #11386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
Merged

[ENG-9622] Contributor claim link temporarily returns “Not Found” before becoming accessible and showing “User has already been claimed.” #11386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/test_adding_contributor_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,7 @@ def test_claim_user_already_registered_redirects_to_claim_user_registered(self,
res = self.app.get(claim_url)

# should redirect to 'claim_user_registered' view
claim_registered_url = f'/user/{unregistered_user._id}/{self.project._id}/claim/verify/{token}/'
claim_registered_url = f'/legacy/user/{unregistered_user._id}/{self.project._id}/claim/verify/{token}/'
assert res.status_code == 302
assert claim_registered_url in res.headers.get('Location')

Expand Down Expand Up @@ -672,7 +672,7 @@ def test_claim_user_already_registered_secondary_email_redirects_to_claim_user_r
res = self.app.get(claim_url)

# should redirect to 'claim_user_registered' view
claim_registered_url = f'/user/{unregistered_user._id}/{self.project._id}/claim/verify/{token}/'
claim_registered_url = f'/legacy/user/{unregistered_user._id}/{self.project._id}/claim/verify/{token}/'
assert res.status_code == 302
assert claim_registered_url in res.headers.get('Location')

Expand Down Expand Up @@ -797,7 +797,7 @@ def test_claim_user_form_redirects_to_password_confirm_page_if_user_is_logged_in
def test_claim_user_when_user_is_registered_with_orcid(self, mock_response_from_ticket):
# TODO: check in qa url encoding
token = self.user.get_unclaimed_record(self.project._primary_key)['token']
url = f'/user/{self.user._id}/{self.project._id}/claim/verify/{token}/'
url = f'/legacy/user/{self.user._id}/{self.project._id}/claim/verify/{token}/'
# logged out user gets redirected to cas login
res1 = self.app.get(url)
assert res1.status_code == 302
Expand Down
2 changes: 1 addition & 1 deletion website/routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,7 +867,7 @@ def make_url_map(app):
# user will be required to verify password
# claim token must be present in query parameter
Rule(
['/user/<uid>/<pid>/claim/verify/<token>/'],
['/legacy/user/<uid>/<pid>/claim/verify/<token>/'],
['get', 'post'],
project_views.contributor.claim_user_registered,
OsfWebRenderer('claim_account_registered.mako', trust=False)
Expand Down
Loading