[ENG-9681] Fix api3 ci and collection submission issues #11410
Closed
+438
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nce#11377) * change route for user claim * fix tests --------- Co-authored-by: Yuhuai Liu <[email protected]> Co-authored-by: Longze Chen <[email protected]>
Hotfix to reroute unregistered contributor claim
…herebetskyi/fix/api3-ci [ENG-9619] Tests for api3 branch turned off
Hotfix for importing contributors from parent project
Johnetordoff
commented
Oct 31, 2025
| def collection(collection_provider): | ||
| collection = CollectionFactory(is_public=True) | ||
| collection.provider = collection_provider | ||
| with capture_notifications(): |
There was a problem hiding this comment.
This would fail because it didn't send notifications.
Johnetordoff
commented
Oct 31, 2025
| def collection(collection_provider): | ||
| collection = CollectionFactory() | ||
| collection.provider = collection_provider | ||
| with capture_notifications(): |
There was a problem hiding this comment.
This would fail because it didn't send notifications.
Johnetordoff
commented
Oct 31, 2025
| collection_submission=collection_submission, | ||
| trigger=moderator_trigger.db_name | ||
| ), auth=test_auth, expect_errors=True) | ||
| with capture_notifications() as notifications: |
There was a problem hiding this comment.
This adds needed email mocking.
Johnetordoff
commented
Oct 31, 2025
| 'api_tests/guids', | ||
| 'api_tests/meetings', | ||
| 'api_tests/metadata_records', | ||
| 'api_tests/osf_groups', |
There was a problem hiding this comment.
Having this one line here forces the whole branch to silently pass automatically, obviously that is bad.
…3-ci-and-collection-submission-issues # Conflicts: # osf/migrations/0032_remove_osfgroup_creator_and_more.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix problems api3 test branch and the collections submissions tests.
Changes
QA Notes
Please make verification statements inspired by your code and what your code touches.
What are the areas of risk?
Any concerns/considerations/questions that development raised?
Documentation
Side Effects
Ticket
https://openscience.atlassian.net/browse/ENG-9681