[SVCS-132] Factor out move/copy code #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erbutler into DRY-move-or-copy * 'develop' of https://github.com/CenterForOpenScience/waterbutler: (40 commits) bump version & update changelog add provider to sentry tags Typo fix Allow sentry to capture node ID for apiv1 errors ignore the new type annotations for gdrive.intra_move undo the previous changes to intra_copy, it only works on files Allow file or folder metadata to be returned instead of just file metadata. Revert "enable retries for WB => Dropbox uploads" enable retries for WB => Dropbox uploads Restore per-incoming-request throttling bump version and update changelog avoid dumping duplicate information to the application log bump version & update changelog fix figshare uploads by swapping read() for readexactly() bump version & update changelog properly format Last-Modified headers from v1 HEAD requests add mypy type ignores to silence errors (for now) add tests for bitbucket provider safely encode most BB file names don't blindy trust metadata_file's parent_dir optimization ... # Conflicts: # waterbutler/core/provider.py
AddisonSchiller
suggested changes
Nov 16, 2017
…erbutler into DRY-move-or-copy * 'develop' of https://github.com/CenterForOpenScience/waterbutler: (118 commits) final cleanups for onedrive make provider readonly start cleaning up and reorganizing onedrive implement Microsoft OneDrive provider using dropbox as base added onedrive provider -- copied from Dropbox don't assume file metadata has a modified/created date add mypy type annotations add modified/created dates to file metadata expand docstrings add ruby serialization workaround to download clean up commit_sha vs. branch_name handling add tests for revisions and uninit-ed repos add artificial test for missing folder remove unused and obsolete code rewrite test suite for provider changes and coverage update some more docstrings on the provider GL provider is read-only: folder creation is not allowed add workaround for non-existent directories not being reported in GL document workarounds in download & _fetch_file_contents remove unneeded error wrapping from metadata ... # Conflicts: # waterbutler/core/provider.py
…terbutler into DRY-move-or-copy * 'DRY-move-or-copy' of https://github.com/johnetordoff/waterbutler: # Conflicts: # waterbutler/core/provider.py
cslzchen
requested changes
Jun 27, 2018
|
Need to make it not a decorator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
If WB core provider the move and copy code repeats itself unnecessarily this factors it out and cleans up the functions substantially.
Changes
Moves the metrics, name handling and intra_move/copy code into a decorator which wraps the move and copy functions, also adds/updates some docstrings. Changes some keyword arguments to positional arguments.
Side Effects
None that I know of.
Ticket
https://openscience.atlassian.net/browse/SVCS-132