Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SVCS-479] Raise exception for copy/move replace folder that orphans itself. #333

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

[SVCS-479] Raise exception for copy/move replace folder that orphans itself. #333

wants to merge 13 commits into from

Commits on Jun 5, 2018

  1. Reject complicated self-overwrites 

    Fixing an issue where when a child component is hooked up
To a project, and they share the same provider, it is
possible to silently delete files
    @AddisonSchiller @NyanHelsing
    AddisonSchiller authored and NyanHelsing committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    a9ba57b View commit details
    Browse the repository at this point in the history

  2. Reworking and refactoring

    @AddisonSchiller @NyanHelsing
    AddisonSchiller authored and NyanHelsing committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    27e6364 View commit details
    Browse the repository at this point in the history

  3. Responding to CR

    @AddisonSchiller @NyanHelsing
    AddisonSchiller authored and NyanHelsing committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    cbec8a1 View commit details
    Browse the repository at this point in the history

  4. Raise exception for copy/move replace folder that orphans itself. 

    [#SVCS-479] Replace folder from inside folder deletes both

Add replace_will_orphan(src_path,dest_path)
Checks if dest_path overwrite will orphan src_path
Call replace_will_orphan in copy/move defs in waterbutler.core.provider
    @TomBaxter @NyanHelsing
    TomBaxter authored and NyanHelsing committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    1acc81c View commit details
    Browse the repository at this point in the history

  5. Refactor overwrite conflict logic 

    SVCS-479

Move three pieces of overwrite conflict logic from move/copy into
handle_naming and rename handle_naming to handle_conflict. Improved
logic and reduced code.
    @TomBaxter @NyanHelsing
    TomBaxter authored and NyanHelsing committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    3e06975 View commit details
    Browse the repository at this point in the history

  6. Finish work on orphan overwrites

    @NyanHelsing
    NyanHelsing committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    187b4d0 View commit details
    Browse the repository at this point in the history

  7. Put boolean ops at end

    @NyanHelsing
    NyanHelsing committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    49d12e6 View commit details
    Browse the repository at this point in the history

  8. Fix module name, linting

    @NyanHelsing
    NyanHelsing committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    aacd550 View commit details
    Browse the repository at this point in the history

  9. Make sure typing imports are unqualified

    @NyanHelsing
    NyanHelsing committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    cf92678 View commit details
    Browse the repository at this point in the history

  10. Fix replace test rename

    @NyanHelsing
    NyanHelsing committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    99c8173 View commit details
    Browse the repository at this point in the history

  11. ...

    @NyanHelsing
    NyanHelsing committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    10ee255 View commit details
    Browse the repository at this point in the history

  12. HTTP Method uniformity 

    There was some places where the http method 'get' was written in
lowercase. this was changed to upper case to match the rest of the
codebase, and broke some tests. This fixes those tests also.
    @NyanHelsing
    NyanHelsing committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    f2edb4d View commit details
    Browse the repository at this point in the history

  13. Ensure HTTP method case uniformity 

    Box's validate_v1_path http method name should be lowercase.
    @NyanHelsing
    NyanHelsing committed Jun 5, 2018
    Configuration menu
    Copy the full SHA
    e012a51 View commit details
    Browse the repository at this point in the history