-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes v0, redirect downloads #355
Open
NyanHelsing
wants to merge
9
commits into
CenterForOpenScience:develop
Choose a base branch
from
NyanHelsing:ft/remove-v0
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Removes v0, redirect downloads #355
NyanHelsing
wants to merge
9
commits into
CenterForOpenScience:develop
from
NyanHelsing:ft/remove-v0
Commits on Aug 14, 2018
-
Removes v0, redirect downloads
Removes all v0 files. these endpoints now return 410 (gone), except for the download action, which rewrites the url to return a redirect to the v1 api endpoint. We may consider writing an nginx directive to handle this as it would be far faster.
Configuration menu - View commit details
-
Copy full SHA for f23c6b5 - Browse repository at this point
Copy the full SHA f23c6b5View commit details -
Fix missing slash, unused imports
Removes some unused imports and adds in a slash that was missiong from the url being redirected to.
Configuration menu - View commit details
-
Copy full SHA for 14de20b - Browse repository at this point
Copy the full SHA 14de20bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb6cdca - Browse repository at this point
Copy the full SHA bb6cdcaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fe375d - Browse repository at this point
Copy the full SHA 9fe375dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f6054f - Browse repository at this point
Copy the full SHA 9f6054fView commit details
Commits on Aug 16, 2018
-
Only v0 uses the fetch method on the auth handler. v1 uses the get method. This removes the fetch method and the tests for it.
Configuration menu - View commit details
-
Copy full SHA for 4df6c22 - Browse repository at this point
Copy the full SHA 4df6c22View commit details -
Remove validate path, and rename validate_v1_path
validate_path is only used by v0, so by removing v0, we can remove validate_path as well. validate_v1_path also gets renamed validate_path to cut down any confusion about the naming
Configuration menu - View commit details
-
Copy full SHA for 1ce86b9 - Browse repository at this point
Copy the full SHA 1ce86b9View commit details -
Some tests only tested validate_path, which has been removed, so these tests were removed. Other tests needed to be updated so that they were mocked correctly because validate_v1_path (now `validate_path`) makes network requests.
Configuration menu - View commit details
-
Copy full SHA for 7ad143c - Browse repository at this point
Copy the full SHA 7ad143cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3286578 - Browse repository at this point
Copy the full SHA 3286578View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.