Basic catalog searching #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgonggrijp
requested changes
Jul 16, 2024
There was a problem hiding this comment.
This looks good to me overall. I made a bunch of comments, but they are about details and not all of them require changes.
(Side note: the comments probably read best on the conversation tab, because the order in which I submitted the comments is not the same as the order in which they appear in the code.)
Merged
Co-authored-by: Julian Gonggrijp <[email protected]>
Co-authored-by: Julian Gonggrijp <[email protected]>
|
Thank you for the thorough review, I learned a lot from it! I have made all the requested changes, I think. |
jgonggrijp
reviewed
Jul 17, 2024
Co-authored-by: Julian Gonggrijp <[email protected]>
Co-authored-by: Julian Gonggrijp <[email protected]>
|
Everything has been addressed now, I will merge the pull request. |
jgonggrijp
added a commit
that referenced
this pull request
Dec 11, 2024
jgonggrijp
added a commit
that referenced
this pull request
Dec 11, 2024
jgonggrijp
added a commit
that referenced
this pull request
Dec 12, 2024
jgonggrijp
added a commit
that referenced
this pull request
Dec 12, 2024
jgonggrijp
added a commit
that referenced
this pull request
Dec 13, 2024
jgonggrijp
added a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow searching using the new catalog system, via an RDF representation in JSON-LD. Showing record details is not yet working, I am working on that in a separate branch. This branch contains the code to make sense of JSON-LD responses with nested information and with a specified order of subjects using the ActivityStreams scheme.
Known issue: #182 (Correctly handle duplicate records in external catalogs)