Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utilise session cleanup for test indices #1746

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

utilise session cleanup for test indices #1746

wants to merge 1 commit into from

Conversation

lukavdplas
Copy link
Contributor

Tiny change to the names used for indices created in unit tests.

The affected indices are now caught by the test_index_cleanup fixture, which removes test indices at the start and end of each session. This fixes a problem where tests may fail because the previous session was not completed (and lingering indices are messing up the test).

@lukavdplas lukavdplas added code quality code & performance improvements that do not affect user functionality backend changes to the django backend labels Jan 30, 2025
BeritJanssen
BeritJanssen approved these changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@BeritJanssen BeritJanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Before you merge: can you check if addcorpus.tests.test_filters.test_date_filter and es.tests.test_sync.test_update_index_availability can lose the direct dependency on test_index_cleanup? In principle, they should be using the test client, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeritJanssen BeritJanssen BeritJanssen approved these changes

Assignees
No one assigned
Labels
backend changes to the django backend code quality code & performance improvements that do not affect user functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukavdplas @BeritJanssen