Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/reorder fields #1747

Merged
merged 6 commits into from
Feb 4, 2025
Merged

Feature/reorder fields #1747

merged 6 commits into from
Feb 4, 2025

Conversation

lukavdplas
Copy link
Contributor

Allows users to change the order of fields in a corpus (part of #1736)

Screenshot:

screenshot of I-analyzer. Shows corpus form with up/down buttons below each field.

@lukavdplas lukavdplas added enhancement improvements to user functionality frontend changes to the angular frontend backend changes to the django backend labels Jan 30, 2025
Copy link
Contributor

@JeltevanBoheemen JeltevanBoheemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! The settimeout and queryselector stuff is giving me jquery vibes ^^

Comment on lines +80 to +84
<!-- the first "move down" and the last "move up" button are disabled;
this is done with CSS/ARIA/javascript rather than the "disabled"
attribute, so the control can stay focused when the user moves
the field to the first/last position.
-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good decision.

@lukavdplas lukavdplas merged commit 6b7d5b8 into develop Feb 4, 2025
2 checks passed
@lukavdplas lukavdplas deleted the feature/reorder-fields branch February 4, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend changes to the django backend enhancement improvements to user functionality frontend changes to the angular frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants