Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more unit tests #16

Merged
merged 38 commits into from
Jun 26, 2024
Merged

more unit tests #16

merged 38 commits into from
Jun 26, 2024

Conversation

lukavdplas
Copy link
Contributor

@lukavdplas lukavdplas commented Apr 24, 2024 •
edited
Loading

Improves test coverage:

  • The CSV reader in unit tests is now the same one used in the documentation, which was a bit more elaborate than the existing test. It's also a good assurance that the example in the documentation actually functions as described.
  • Added unit tests for various options in the XML extractor. Close Add unit tests for XML extraction #7
  • Added unit tests for all the generic extractors (Choice, Backup, Combined, etc); close Unit tests for meta-extractors #13
  • Removed the (non-functioning) test based on the Times corpus.

@lukavdplas lukavdplas requested a review from BeritJanssen April 24, 2024 13:13
lukavdplas added 23 commits April 25, 2024 17:21
@lukavdplas
add test for secondary_tag
347c1db
@lukavdplas
add documentation for secondary_tag
cf99861
@lukavdplas
add test for multiple attributes
b773091
@lukavdplas
add test for xml external file
56ae944
@lukavdplas
fix typo
4181965
@lukavdplas
define XMLTag class
a97d292
@lukavdplas
add _soup_and_metadata_from_source method
445158b
@lukavdplas
implement XMLTag for tag_toplevel and tag_entry
566761c
@lukavdplas
use XMLTag in XML extractor
2ad3c03
@lukavdplas
adjust sibling tag argument
a670a3e
@lukavdplas
implement ParentTag class
efa860c
@lukavdplas
add FindParentTag class
9b45ef1
@lukavdplas
add SiblingTag class
d7f169b
@lukavdplas
clearer code for resolving tags
2fc70a0
@lukavdplas
make find_in_soup return an iterable
ad7765c
@lukavdplas
refactor _select method
c1069ee
@lukavdplas
remove sibling_tag argument to XML
2d1cdcc
@lukavdplas
replace transform_soup_func with TransformTag
1bfa2a9
@lukavdplas
use CurrentTag class instead of None for tags
173a215
@lukavdplas
use filename in logging messages
ef42f1d
@lukavdplas
clarify handling of external files
e4f00f9
@lukavdplas
update docstrings
fca8da0
@lukavdplas
unify _resolve_tag methods
8cfe5bd
@lukavdplas lukavdplas requested review from Meesch and removed request for BeritJanssen May 15, 2024 14:08
@lukavdplas lukavdplas merged commit 57a2d32 into develop Jun 26, 2024
8 checks passed
@lukavdplas lukavdplas deleted the feature/expand-unit-tests branch June 26, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Meesch Meesch Awaiting requested review from Meesch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit tests for meta-extractors Add unit tests for XML extraction
1 participant
@lukavdplas