This repository has been archived by the owner on Nov 29, 2024. It is now read-only.
auction-bid-collateral: extract code from FREEP-605 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naure
force-pushed
the
auction-bid-collateral
branch
from
664fa4a to
35e3348
Compare
naure
commented
Sep 1, 2022
| @@ -221,6 +222,8 @@ contract SimpleAuction is /* AccessControl, */ MetaTxContext, ERC1155HolderUpgra | |||
|
|
|||
| // Transfer the NFT to the buyer. | |||
| freeport.transferFrom(address(this), buyer, nftId, 1); | |||
| // Tracking amount of collateral NFTs | |||
| bidCollateral[seller][nftId] = 0; | |||
There was a problem hiding this comment.
Why not -1 ? I mean based on other constraints this always be 1 at this stage but that’d be more logical.
@neanvo
There was a problem hiding this comment.
Because it's not compatible with existing bids, that need to be decreased but counter is already 0
|
@neanvo And do we need this? If what we want is that the clients can found out whether they have an NFT locked in an auction, they can read the variable We could write a simple getter too: |
|
@naure Sounds reasonable. For the current implementation it might be the case. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@neanvo I don’t understand the point of this.