-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jsonOnly
option to merge
command
#140
Conversation
This option is meant to avoid copying resources (tileset.json and tile contents) when merging multiple input tilesets. Results in a tileset.json that references input tilesets where they are stored.
Need to convert CRLF to LF endings
… than using a `--jsonOnly` flag
Thanks. I tried it out locally, and ran the tests, and verified that the CLA was signed, and everything seems to be fine.... ...except for that line endings thing. Quickly looking at the documentation, it seems like There's still the question about the line endings, though: I'll have to check what the best practices/policies are here. This should be unrelated to this PR, and may be handled in a small cleanup PR later. |
Woops sorry for pushing that change in package.json. Indeed this was just testing on my side, I reverted to the original package.json prettier command. Edit: Note I also tried enforcing line endings to # .gitattributes
# Auto detect text files and perform LF normalization
* text eol=lf
|
Yes, it seems like using a Thanks again for the (I'm usually updating things like the CHANGES.md and README.md prior to a release. So I'll probably schedule a release soon, and then also update these files accordingly) |
Thanks for helping me design that PR, and happy that I could help! |
Following discussion thread #44
This option is meant to avoid copying resources (tileset.json and tile contents) when merging multiple input tilesets. Results in a tileset.json that references input tilesets where they are stored.
Can add another commit to remove the
--jsonOnly
flag from themerge
command to instead create a new command,mergeJson