Take glTF up axis into account during upgrade #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #165
What this currently does:
tileset.asset.gltfUpAxis
It could be desirable to also use this for the
upgrade
to 1.0: ThegltfUpAxis
is a "legacy" feature that should not be part of a tileset that has been upgraded to 1.0. And this might be doable with reasonable effort.What I'm more scared of is that the
gltfUpAxis
also (likely) will affect the I3DM upgrade. The coordinate system conversions for I3DM had been a hassle. The coordinate system conversions for thegltfUpAxis
are a hassle. Combining this will be hassle², with the caveat that this involves generating that "legacy" data in the first place...The current test data (which is not yet checked in, and might still change) is here:
upAxisHandling 2025-01-08.zip
It focusses on the B3DM case (with and without an
RTC_CENTER
in the B3DM), and makes sure that the visual appearance of the output is still the same as the input in CesiumJS (Sandcastle and output are included)This is supposed to eventually become a test data set for the specs, using the "golden" comparison approach.