Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Section structure and link pass #673

Merged
merged 7 commits into from
Mar 16, 2022

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Mar 16, 2022

Some points from the checklist at #651 include

  • Fix broken links
  • Remove mentions of 3D Tiles Next
  • Refer to 1.1 sections instead of extensions wherever applicable

This PR will collect some of the related fixes.

@javagl
Copy link
Contributor Author

javagl commented Mar 16, 2022

Until now, I noticed some broken links in the main README, related to "contents", "multiple contents", "content groups" and "group metadata", and I tried to reorganize that by introducing a dedicated "Tile Contents" section that explains contents, multiple contents, and groups, so that it is possible to refer to this section where appropriate. The current state is a DRAFT, for early feedback whether the new structure makes sense.


![](figures/multiple-contents-geometry.png)

The `content.uri` of each content object refers to the tile's binary content in one of the tile formats that are defined in the [Tile format specifications](#tile-format-specifications)), or another tileset JSON to create a tileset of tilesets (see [External tilesets](#external-tilesets)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

binary content

Not all tile formats are binary any more, notably .gltf

(I see this was copied from some outdated text below)

@lilleyse
Copy link
Contributor

The current state is a DRAFT, for early feedback whether the new structure makes sense.

The structure looks good to me.

@javagl
Copy link
Contributor Author

javagl commented Mar 16, 2022

I did a pass for checking the links. In addition to the TODO links that had been marked as such, a general remark: There had been several links of the form

A tile's [`transform`](../../specification#tile-transforms)

where the #tile-transforms fragment refers to the anchor in the README.md in the givem directory. I think that this is working rather coincidentally, because GitHub is showing the README.md when accessing a directory (in addition to the directory contents at the top).

(An aside: I didn't try out what happens when there is a (markdown) file (!) called specification in this directory, and it contains (or does not contain) an anchor #tile-transforms, but ... it would likely no longer refer to the README.md automatically, and be confusing in any case...)

Links of this form are probably not "valid" in the strictest sense. At least, they do not allow browsing to them with a CTRL+Click in VSCode, for example. So I changed them to

A tile's [`transform`](../../specification/README.md#tile-transforms)

where appropriate.

@javagl
Copy link
Contributor Author

javagl commented Mar 16, 2022

We still have to sort out whether the extensions directory should be split into an extensions/1.0 and an extensions/1.1 directory - at least to make clear that the current extensions are nearly all only supposed to be used with 3D Tiles 1.0, and basically no longer used ("deprecated") in 3D Tiles 1.1. (Yes, what about the S2 extension, which applies to both...?)

@javagl javagl marked this pull request as ready for review March 16, 2022 19:36
Comment on lines -37 to -46
### Upcoming

[3D Tiles Next](./next) is a set of new capabilities for the future of 3D Tiles. Provided as draft extensions to the [3D Tiles 1.0](../specification) specification, these features may be incorporated into 3D Tiles 2.0 in the future.

- [Tile Content](./next#tile-content): glTF 2.0 assets may be used directly as tile content, without intermediate formats, improving interoperability with 3D content and tooling ecosystems. Tiles may reference multiple contents — for organization, styling, and filtering — and contents may be collected into groups similar to map layers in mapping applications.
- [Implicit Tiling](./next#implicit-tiling): Common subdivision schemes and spatial index patterns may be declared without listing bounding volumes exhaustively. Reduces tileset size, and enables new optimizations including faster traversal, raycasting, random access, and spatial queries.
- [Metadata](./next#metadata): Metadata in 3D Tiles gains more expressiveness and flexibility, with a well-defined type system, new encoding options (e.g. JSON or binary), and a range of granularity options. Metadata may be associated with high-level objects like tilesets, tiles, or tile content groups, or with individual vertices and texels on glTF 2.0 geometry.

A curated list of resources for developers can be found on the [3D Tiles Next Resources](./next/RESOURCES.md) page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be replaced by a more formal version history. That's what this checkbox in #651 was about:

  • Add version history (include deprecations)

Doesn't have to hold up this PR though.

@lilleyse lilleyse merged commit f8d3985 into CesiumGS:draft-1.1 Mar 16, 2022
@javagl javagl mentioned this pull request Mar 17, 2022
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants