Skip to content

Update cesium-native #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 27, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions extern/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ endif()
option(BUILD_SHARED_LIB OFF)
option(SUPPORT_CONSOLE_APP OFF)
set(LIB_INSTALL_DIR ${CMAKE_INSTALL_LIBDIR})
set(CMAKE_POLICY_VERSION_MINIMUM "3.5")
add_subdirectory(tidy-html5)

# Don't build the cesium-native tests by default
Expand Down
2 changes: 1 addition & 1 deletion extern/cesium-native
Submodule cesium-native updated 36 files
+2 −2 .github/workflows/build.yml
+8 −8 .github/workflows/prod.yml
+17 −0 CHANGES.md
+4 −2 CMakeLists.txt
+14 −3 Cesium3DTilesContent/include/Cesium3DTilesContent/SubtreeAvailability.h
+123 −55 Cesium3DTilesContent/src/SubtreeAvailability.cpp
+59 −1 Cesium3DTilesContent/test/TestSubtreeAvailability.cpp
+29 −2 Cesium3DTilesSelection/include/Cesium3DTilesSelection/Tile.h
+1 −1 Cesium3DTilesSelection/src/EllipsoidTilesetLoader.cpp
+2 −3 Cesium3DTilesSelection/src/ImplicitOctreeLoader.cpp
+2 −3 Cesium3DTilesSelection/src/ImplicitQuadtreeLoader.cpp
+1 −1 Cesium3DTilesSelection/src/LayerJsonTerrainLoader.cpp
+8 −3 Cesium3DTilesSelection/src/Tile.cpp
+5 −3 Cesium3DTilesSelection/src/TilesetJsonLoader.cpp
+64 −0 Cesium3DTilesSelection/test/TestImplicitOctreeLoader.cpp
+64 −0 Cesium3DTilesSelection/test/TestImplicitQuadtreeLoader.cpp
+4 −0 Cesium3DTilesSelection/test/TestTilesetContentManager.cpp
+3 −4 Cesium3DTilesSelection/test/TestTilesetSelectionAlgorithm.cpp
+30 −6 Cesium3DTilesWriter/include/Cesium3DTilesWriter/SubtreeWriter.h
+116 −2 Cesium3DTilesWriter/src/SubtreeWriter.cpp
+520 −0 Cesium3DTilesWriter/test/TestSubtreeWriter.cpp
+27 −0 Cesium3DTilesWriter/test/TestTilesetWriter.cpp
+2 −2 CesiumGltfWriter/include/CesiumGltfWriter/GltfWriter.h
+20 −20 CesiumGltfWriter/test/TestGltfWriter.cpp
+8 −1 cmake/macros/configure_cesium_library.cmake
+2 −0 extern/vcpkg/ports/README.md
+0 −122 extern/vcpkg/ports/ktx/0001-Use-vcpkg-zstd.patch
+0 −17 extern/vcpkg/ports/ktx/0002-Fix-versioning.patch
+0 −13 extern/vcpkg/ports/ktx/0003-mkversion.patch
+0 −21 extern/vcpkg/ports/ktx/0004-quirks.patch
+0 −17 extern/vcpkg/ports/ktx/0005-no-vendored-libs.patch
+0 −22 extern/vcpkg/ports/ktx/0006-fix-ios-install.patch
+0 −81 extern/vcpkg/ports/ktx/portfile.cmake
+0 −36 extern/vcpkg/ports/ktx/vcpkg.json
+2 −0 extern/vcpkg/triplets/README.md
+5 −2 vcpkg-configuration.json
31 changes: 31 additions & 0 deletions extern/vcpkg-overlays/ada-url/no-cpm.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
index b206edb6..1db4099d 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -30,7 +30,6 @@ option(ADA_TESTING "Build tests" ${BUILD_TESTING})
# errors due to CPM, so this is here to support disabling all the testing
# and tooling for ada if one only wishes to use the ada library.
if(ADA_TESTING OR ADA_BENCHMARKS OR ADA_TOOLS)
- include(cmake/CPM.cmake)
# CPM requires git as an implicit dependency
find_package(Git QUIET)
# We use googletest in the tests
diff --git a/tools/cli/CMakeLists.txt b/tools/cli/CMakeLists.txt
index ff57220b..a6d90f29 100644
--- a/tools/cli/CMakeLists.txt
+++ b/tools/cli/CMakeLists.txt
@@ -8,12 +8,8 @@ if(MSVC AND BUILD_SHARED_LIBS)
"$<TARGET_FILE:ada>" # <--this is in-file
"$<TARGET_FILE_DIR:adaparse>") # <--this is out-file path
endif()
-CPMAddPackage("gh:fmtlib/fmt#10.2.1")
-CPMAddPackage(
- GITHUB_REPOSITORY jarro2783/cxxopts
- VERSION 3.2.0
- OPTIONS "CXXOPTS_BUILD_EXAMPLES NO" "CXXOPTS_BUILD_TESTS NO" "CXXOPTS_ENABLE_INSTALL YES"
-)
+find_package(fmt CONFIG REQUIRED)
+find_package(cxxopts CONFIG REQUIRED)
target_link_libraries(adaparse PRIVATE cxxopts::cxxopts fmt::fmt)

if(MSVC OR MINGW)
40 changes: 40 additions & 0 deletions extern/vcpkg-overlays/ada-url/portfile.cmake
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO ada-url/ada
REF "v${VERSION}"
SHA512 bc876db537153d6b0599215ca8be8261bceca6d213fcc63af5fda13c1b32876496cb8d4e98c787f17317cf8ffd1940431551513807f1a18f9ce993fad35f5ec6
HEAD_REF main
PATCHES
no-cpm.patch
)

vcpkg_check_features(
OUT_FEATURE_OPTIONS FEATURE_OPTIONS
FEATURES
tools ADA_TOOLS
)

vcpkg_cmake_configure(
SOURCE_PATH "${SOURCE_PATH}"
OPTIONS
-DADA_BENCHMARKS=OFF
-DBUILD_TESTING=OFF
-DCMAKE_DISABLE_FIND_PACKAGE_Python3=ON
${FEATURE_OPTIONS}
OPTIONS_DEBUG
-DADA_TOOLS=OFF
)

vcpkg_cmake_install()

vcpkg_copy_pdbs()

vcpkg_cmake_config_fixup(PACKAGE_NAME ada CONFIG_PATH "lib/cmake/ada")

if("tools" IN_LIST FEATURES)
vcpkg_copy_tools(TOOL_NAMES adaparse AUTO_CLEAN)
endif()

file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include")

vcpkg_install_copyright(FILE_LIST "${SOURCE_PATH}/LICENSE-APACHE" "${SOURCE_PATH}/LICENSE-MIT")
27 changes: 27 additions & 0 deletions extern/vcpkg-overlays/ada-url/vcpkg.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
{
"name": "ada-url",
"version": "2.9.2",
"description": "WHATWG-compliant and fast URL parser written in modern C++",
"homepage": "https://ada-url.com/",
"license": "MIT",
"dependencies": [
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
],
"features": {
"tools": {
"description": "Build CLI tools (adaparse)",
"supports": "!uwp",
"dependencies": [
"cxxopts",
"fmt"
]
}
}
}
21 changes: 0 additions & 21 deletions extern/vcpkg-overlays/asyncplusplus/portfile.cmake

This file was deleted.

18 changes: 0 additions & 18 deletions extern/vcpkg-overlays/asyncplusplus/vcpkg.json

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
diff --git a/CMakeLists.txt b/CMakeLists.txt
index ffcbe95..7b13753 100644
index 8f0fff3..9875e97 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -490,7 +490,7 @@ macro(common_libktx_settings target enable_write library_type)
@@ -505,7 +505,7 @@ macro(common_libktx_settings target enable_write library_type)
target_compile_definitions(
${target}
PUBLIC
Expand Down
12 changes: 7 additions & 5 deletions extern/vcpkg-overlays/ktx/portfile.cmake
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
vcpkg_from_git(
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
URL "https://github.com/KhronosGroup/KTX-Software.git"
REF 91ace88675ac59a97e55d0378a6602a9ae6b98bd
FETCH_REF "v${VERSION}"
HEAD_REF main
REPO KhronosGroup/KTX-Software
REF "v${VERSION}"
SHA512 0077315fe2b4e676e97e3a158c2c6e1f6ba426e14ad23342592cd69be28cfce64c40614e0a84d58a9634877ab334e713b94d4c962132c98bfea308e91bc8a98a
HEAD_REF master
PATCHES
0001-Use-vcpkg-zstd.patch
0002-Fix-versioning.patch
Expand All @@ -14,6 +14,8 @@ vcpkg_from_git(
CESIUM-0001-do-not-define-_DEBUG.patch
)
file(REMOVE "${SOURCE_PATH}/other_include/zstd_errors.h")
file(REMOVE_RECURSE "${SOURCE_PATH}/external/basisu/zstd")
file(REMOVE_RECURSE "${SOURCE_PATH}/lib/basisu/zstd")

vcpkg_list(SET OPTIONS)
if(VCPKG_TARGET_IS_WINDOWS)
Expand Down
1 change: 1 addition & 0 deletions extern/vcpkg-overlays/ktx/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "ktx",
"version-semver": "4.3.2",
"port-version": 2,
"description": [
"The Khronos KTX library and tools.",
"Functions for writing and reading KTX files, and instantiating OpenGL®, OpenGL ES™️ and Vulkan® textures from them."
Expand Down
36 changes: 0 additions & 36 deletions extern/vcpkg-overlays/zlib-ng/portfile.cmake

This file was deleted.

13 changes: 0 additions & 13 deletions extern/vcpkg-overlays/zlib-ng/vcpkg.json

This file was deleted.