Skip to content

Commit

Permalink
Merge pull request #12504 from CesiumGS/longer-deprecation
Browse files Browse the repository at this point in the history
Extend recommended deprecation window
  • Loading branch information
ggetz authored Feb 28, 2025
2 parents dc81cd5 + c89fd00 commit 69c7e18
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 6 deletions.
2 changes: 1 addition & 1 deletion Documentation/Contributors/CodingGuide/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -923,7 +923,7 @@ An `@experimental` API is subject to breaking changes in future Cesium releases

A public identifier (class, function, property) should be deprecated before being removed. To do so:

- Decide on which future version the deprecated API should be removed. This is on a case-by-case basis depending on how badly it impacts users and Cesium development. Most deprecated APIs will removed in 1-3 releases. This can be discussed in the pull request if needed.
- Decide on which future version the deprecated API should be removed. This is on a case-by-case basis depending on how badly it impacts users and Cesium development. Most deprecated APIs will removed in 3-6 releases. This can be discussed in the pull request if needed.
- Use [`deprecationWarning`](https://github.com/CesiumGS/cesium/blob/main/Source/Core/deprecationWarning.js) to warn users that the API is deprecated and what proactive changes they can take, e.g.,

```javascript
Expand Down
4 changes: 0 additions & 4 deletions packages/engine/Source/Renderer/Context.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import ComponentDatatype from "../Core/ComponentDatatype.js";
import createGuid from "../Core/createGuid.js";
import defaultValue from "../Core/defaultValue.js";
import defined from "../Core/defined.js";
import deprecationWarning from "../Core/deprecationWarning.js";
import destroyObject from "../Core/destroyObject.js";
import DeveloperError from "../Core/DeveloperError.js";
import Geometry from "../Core/Geometry.js";
Expand Down Expand Up @@ -1671,7 +1670,4 @@ Context.prototype.destroy = function () {
return destroyObject(this);
};

// Used for specs.
Context._deprecationWarning = deprecationWarning;

export default Context;
1 change: 0 additions & 1 deletion packages/engine/Specs/Renderer/ContextSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ describe(

beforeAll(function () {
context = createContext();
spyOn(Context, "_deprecationWarning");
});

afterAll(function () {
Expand Down

0 comments on commit 69c7e18

Please sign in to comment.