3d tiles terrain #12963
Draft
3d tiles terrain #12963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ior that resolves values immediately
3D Tiles terrain water mask
added 8 commits
March 12, 2025 15:07
|
Thank you for the pull request, @jjhembd! ✅ We can confirm we have a CLA on file for you. |
jjhembd
commented
Oct 17, 2025
| }); | ||
|
|
||
| if (!defined(bufferLoader)) { | ||
| bufferLoader = resourceCache.addBufferLoader({ |
There was a problem hiding this comment.
Both resourceCache.getEmbeddedBufferLoader and .addBufferLoader call ResourceCacheKey.getEmbeddedBufferCacheKey, which involves expensive URI parsing. For other 3D Tilesets, we have previously found that URI parsing can be a bottleneck.
We may want to consider reverting to the old getEmbeddedBufferLoader syntax, which re-used the key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO
See restrictions on the structure of 3D Tiles data to be used as terrain: #12296 (comment)
Issue number and link
Resolves #12296
Testing plan
TODO before moving this out of "Draft":
Checkcalls:EllipsoidalOccluder,GoogleEarthEnterpriseTerrainData,TerrainEncoding(separate from other changes in file),binarySearch,mergeSort,QuantizedMeshTerrainDataSpec. Beware incorrect capitalizations like{Object},{Number[]}! See Clean up docs and type checks for terrain providers #12969ResourceCache. The newgetEmbeddedBufferLoader->addBufferLoadersequence involves additional URI parsing, which has performance implications.TerrainEncodingAuthor checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change