Fix drawCommand model matrix for instanced GaussianSplatPrimitive #12987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ratch matrix as their draw command model matrix The draw command doesn't take ownership of the underlying matrix, so whichever tileset went last won causing tilesets to shift incorrectly draw command owner was also incorrectly set as "this" instead of primitive.
|
Thank you for the pull request, @keyboardspecialist! ✅ We can confirm we have a CLA on file for you. |
|
Maybe change to be aMatrix3 while you're at it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building the draw command, we were using a scratch matrix which got passed along with the draw command. Any subsequent tilesets that pushed commands would reuse that same matrix causing tilesets to erratically shift from using an incorrect model matrix.
Also correctly sets draw command ownership.
Issue number and link
Fixes #12967
Testing plan
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change