Skip to content
This repository has been archived by the owner on May 9, 2024. It is now read-only.

fix: retry indexing the same block range on handler failure #353

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

mpetrun5
Copy link
Member

Restarts loop on the same block range if event handler returns an error.

Adds tests for listener logic (some redundant tests that are copied from another file were over it so it looks a bit weird in git)

Description

Related Issue Or Context

Closes: #352

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions
Copy link

Go Test coverage is 65.2 %\ ✨ ✨ ✨

@github-actions
Copy link

Go Test coverage is 65.2 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 requested a review from P1sar October 16, 2023 12:09
@github-actions
Copy link

Go Test coverage is 65.2 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 merged commit c06ed31 into main Oct 16, 2023
5 checks passed
@mpetrun5 mpetrun5 deleted the mpetrun5/fix-listener-skipping-block-ranges branch October 16, 2023 15:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Retry indexing from the same block range on handler failure
4 participants