Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: store 'block_until' in persistent storage #133

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Feb 3, 2025

Summary of changes

Changes introduced in this pull request:

  • The Durable Object is clearing out its in-memory state more often than I expected. This PR moves the state into persistent storage.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code
    adheres to the team's
    documentation standards,
  • I have added tests that prove my fix is effective or that my feature works
    (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes
    should be reflected in this document.

@lemmih lemmih marked this pull request as ready for review February 3, 2025 10:32
@lemmih lemmih requested a review from a team as a code owner February 3, 2025 10:32
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 10.02%. Comparing base (3dd52e9) to head (dc71b52).

Files with missing lines Patch % Lines
src/rate_limiter.rs 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #133      +/-   ##
==========================================
- Coverage   10.10%   10.02%   -0.08%     
==========================================
  Files          25       25              
  Lines        1277     1287      +10     
==========================================
  Hits          129      129              
- Misses       1148     1158      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Feb 3, 2025
@lemmih lemmih removed this pull request from the merge queue due to a manual request Feb 3, 2025
@lemmih lemmih enabled auto-merge February 3, 2025 10:39
@lemmih lemmih added this pull request to the merge queue Feb 3, 2025
Merged via the queue into main with commit b49448a Feb 3, 2025
5 checks passed
@lemmih lemmih deleted the lemmih/rate-limiter-transactional-storage branch February 3, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants