Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different rate limiter for calibnet and mainnet #142

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

sudo-shashank
Copy link
Contributor

Summary of changes

Changes introduced in this pull request:

  • Independent rate limitter for calibnet(60secs) and mainnet(600 secs)

Reference issue to close (if applicable)

Closes #137

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code
    adheres to the team's
    documentation standards,
  • I have added tests that prove my fix is effective or that my feature works
    (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes
    should be reflected in this document.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 30 lines in your changes missing coverage. Please review.

Project coverage is 9.83%. Comparing base (88f8587) to head (84812ec).

Files with missing lines Patch % Lines
src/faucet/utils.rs 0.00% 12 Missing ⚠️
src/rate_limiter.rs 0.00% 12 Missing ⚠️
src/faucet/controller.rs 0.00% 4 Missing ⚠️
src/faucet/views.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #142      +/-   ##
========================================
- Coverage   9.95%   9.83%   -0.12%     
========================================
  Files         25      25              
  Lines       1296    1311      +15     
========================================
  Hits         129     129              
- Misses      1167    1182      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sudo-shashank sudo-shashank marked this pull request as ready for review February 12, 2025 11:11
@sudo-shashank sudo-shashank requested a review from a team as a code owner February 12, 2025 11:11
@sudo-shashank sudo-shashank added this pull request to the merge queue Feb 12, 2025
Merged via the queue into main with commit 7a327d3 Feb 12, 2025
5 checks passed
@sudo-shashank sudo-shashank deleted the shashank/split-rate-limiter branch February 12, 2025 11:27
LesnyRumcajs added a commit that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split rate limitting between calibnet and mainnet
3 participants