Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: add prebuilt env, document nix setup, add nix commands #143

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Feb 13, 2025

Summary of changes

Changes introduced in this pull request:

  • nixify setup
  • extend readme
  • gh workflow

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code
    adheres to the team's
    documentation standards,
  • I have added tests that prove my fix is effective or that my feature works
    (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes
    should be reflected in this document.

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.83%. Comparing base (7a327d3) to head (af4502a).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #143   +/-   ##
=====================================
  Coverage   9.83%   9.83%           
=====================================
  Files         25      25           
  Lines       1311    1311           
=====================================
  Hits         129     129           
  Misses      1182    1182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lemmih lemmih marked this pull request as ready for review February 14, 2025 09:44
@lemmih lemmih requested a review from a team as a code owner February 14, 2025 09:44
@lemmih
Copy link
Contributor Author

lemmih commented Feb 14, 2025

CI is running both Nix and non-nix configuration to test robustness.

@@ -31,6 +31,70 @@ Running `yarn start` will spawn a local copy of the explorer.
To speed up the build during development, you can run `yarn dev` which will skip
the optimization step.

## Nix Development
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd move this to a separate markdown file (but still leave the mention and link in the README). It's a bit specialized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants