chore: upgrade rust toolchain to 1.80.0 (#4614)

rust-toolchain.toml

@@ -1,3 +1,3 @@
 [toolchain]
-channel = "1.79.0"
+channel = "1.80.0"
 components = ["clippy", "llvm-tools-preview", "rustfmt"]

src/db/gc/mod.rs

@@ -28,10 +28,10 @@
 //!
 //! ## GC Workflow
 //! 1. Mark: traverse all the blocks, generating integer hash representations for each identifier
-//! and storing those in a set.
+//!    and storing those in a set.
 //! 2. Wait at least `chain finality` blocks.
 //! 3. Traverse reachable blocks starting at the current heaviest tipset and remove those from the
-//! marked set, leaving only unreachable entries that are older than `chain finality`.
+//!    marked set, leaving only unreachable entries that are older than `chain finality`.
 //! 4. Sweep, removing all the remaining marked entries from the database.
 //!
 //! ## Correctness
@@ -46,9 +46,9 @@
 //! The expected disk usage is slightly greater than the size of live data for three reasons:
 //! 1. Unreachable data is not removed until it is at least 7.5 hours old (see `chain finality`).
 //! 2. The garbage collector is conservative and is expected to leave a small (less than 1%) amount
-//! of unreachable data behind.
+//!    of unreachable data behind.
 //! 3. The blockstore back-end may be fragmented, therefore not relinquishing the disk space back to
-//! the OS.
+//!    the OS.
 //!
 //! ## Memory usage
 //! During the `mark` and up to the `sweep` stage, the algorithm requires `4 bytes` of memory for
@@ -58,9 +58,9 @@
 //!
 //! ## Scheduling
 //! 1. GC is triggered automatically and there have to be at least `chain finality` epochs stored
-//! for the `mark` step.
+//!    for the `mark` step.
 //! 2. The `filter` step is triggered after at least `chain finality` has passed since the `mark`
-//! step.
+//!    step.
 //! 3. Then, the `sweep` step happens.
 //! 4. Finally, the algorithm waits for a configured amount of time to initiate the next run.
 //!

src/ipld/util.rs

@@ -138,8 +138,8 @@ impl<DB, T> ChainStream<DB, T> {
 /// * `db` - A database that implements [`Blockstore`] interface.
 /// * `tipset_iter` - An iterator of [`Tipset`], descending order `$child -> $parent`.
 /// * `stateroot_limit` - An epoch that signifies how far back we need to inspect tipsets,
-/// in-depth. This has to be pre-calculated using this formula: `$cur_epoch - $depth`, where `$depth`
-/// is the number of `[`Tipset`]` that needs inspection.
+///   in-depth. This has to be pre-calculated using this formula: `$cur_epoch - $depth`, where `$depth`
+///   is the number of `[`Tipset`]` that needs inspection.
 pub fn stream_chain<DB: Blockstore, T: Iterator<Item = Tipset> + Unpin>(
     db: DB,
     tipset_iter: T,
@@ -314,8 +314,8 @@ impl<DB, T> UnorderedChainStream<DB, T> {
 /// * `db` - A database that implements [`Blockstore`] interface.
 /// * `tipset_iter` - An iterator of [`Tipset`], descending order `$child -> $parent`.
 /// * `stateroot_limit` - An epoch that signifies how far back we need to inspect tipsets, in-depth.
-/// This has to be pre-calculated using this formula: `$cur_epoch - $depth`, where `$depth` is the
-/// number of `[`Tipset`]` that needs inspection.
+///   This has to be pre-calculated using this formula: `$cur_epoch - $depth`, where `$depth` is the
+///   number of `[`Tipset`]` that needs inspection.
 #[allow(dead_code)]
 pub fn unordered_stream_chain<
     DB: Blockstore + Sync + Send + 'static,

src/key_management/wallet.rs

@@ -3,14 +3,15 @@
 
 use std::{convert::TryFrom, str::FromStr};
 
+use super::{errors::Error, wallet_helpers, KeyInfo, KeyStore};
 use crate::shim::{address::Address, crypto::SignatureType};
-use ahash::HashMap;
 use serde::{Deserialize, Serialize};
 
 #[cfg(test)]
-use {crate::shim::crypto::Signature, ahash::HashMapExt as _};
-
-use super::{errors::Error, wallet_helpers, KeyInfo, KeyStore};
+use {
+    crate::shim::crypto::Signature,
+    ahash::{HashMap, HashMapExt as _},
+};
 
 /// A key, this contains a `KeyInfo`, an address, and a public key.
 #[derive(Clone, PartialEq, Debug, Eq, Serialize, Deserialize)]
@@ -40,6 +41,7 @@ impl TryFrom<KeyInfo> for Key {
 // - keystore which is a HashMap of KeyInfos resolved by their Address
 /// A wallet is a collection of private keys with optional persistence and
 /// optional encryption.
+#[cfg(test)]
 #[derive(Clone, PartialEq, Debug, Eq)]
 pub struct Wallet {
     keys: HashMap<Address, Key>,

src/rpc/mod.rs

@@ -565,6 +565,7 @@ mod tests {
     // `cargo test --lib -- --exact 'rpc::tests::openrpc'`
     // `cargo insta review`
     #[test]
+    #[ignore = "https://github.com/ChainSafe/forest/issues/4032"]
     fn openrpc() {
         for path in [ApiPath::V0, ApiPath::V1] {
             let _spec = super::openrpc(path, None);
@@ -575,7 +576,6 @@ mod tests {
             //                  more stable.
             //                  (We still run this test to make sure we're not
             //                  violating other invariants)
-            #[cfg(never)]
             insta::assert_yaml_snapshot!(_spec);
         }
     }

src/utils/db/car_stream.rs

@@ -44,6 +44,7 @@ impl CarBlock {
     pub fn write(&self, mut writer: &mut impl io::Write) -> io::Result<()> {
         let frame_length = self.cid.encoded_len() + self.data.len();
         writer.write_all(&frame_length.encode_var_vec())?;
+        #[allow(clippy::needless_borrows_for_generic_args)]
         self.cid
             .write_bytes(&mut writer)
             .map_err(|e| io::Error::new(io::ErrorKind::InvalidData, e))?;

src/utils/io/mod.rs

@@ -3,7 +3,6 @@
 
 mod mmap;
 pub mod progress_log;
-mod tempfile;
 mod writer_checksum;
 
 use std::{

src/utils/io/progress_log.rs

@@ -7,6 +7,7 @@
 //! - They behaved poorly together with regular logging
 //! - They were too verbose and printed even for very small tasks (less than 5 seconds)
 //! - They were only used when connected to a TTY and not written in log files
+//!
 //! This lead us to develop our own logging code.
 //! This module provides two new types for logging progress that are [`WithProgress`] and [`WithProgressRaw`].
 //! The main goal of [`WithProgressRaw`] is to maintain a similar API to the previous one from progress bar so we could remove the [`indicatif`](https://crates.io/crates/indicatif) dependency,