Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bootstrapping tests #4581

Merged
merged 7 commits into from
Jul 26, 2024
Merged

feat: bootstrapping tests #4581

merged 7 commits into from
Jul 26, 2024

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Jul 23, 2024

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs force-pushed the bootstrapper-ci branch 4 times, most recently from da1eecf to 8db0a52 Compare July 23, 2024 17:30
@LesnyRumcajs
Copy link
Member Author

Likely out of disk space, may need to tinker around given a 4 GB snapshot is tossed around on a 14 GB machine. Or move to a paid runner.

@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review July 24, 2024 13:48
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner July 24, 2024 13:48
@LesnyRumcajs LesnyRumcajs requested review from lemmih and hanabi1224 and removed request for a team July 24, 2024 13:48
@LesnyRumcajs LesnyRumcajs enabled auto-merge July 25, 2024 15:15
FROM ubuntu:22.04

# Need to copy the relevant shared libraries from the builder image.
# See https://github.com/filecoin-project/lotus/blob/master/Dockerfile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer a permalink to a tagged release

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not useful in the context of a constantly updated tag. Do you agree that bumping the Lotus version only in the environment file is more maintainable that going through all the linked permalinks?

@ruseinov ruseinov self-requested a review July 26, 2024 09:47
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jul 26, 2024
Merged via the queue into main with commit 9b3861a Jul 26, 2024
30 checks passed
@LesnyRumcajs LesnyRumcajs deleted the bootstrapper-ci branch July 26, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants