Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Eth Event Filter API's #4615

Closed
wants to merge 18 commits into from
Closed

Conversation

sudo-shashank
Copy link
Contributor

@sudo-shashank sudo-shashank commented Aug 5, 2024

Summary of changes

Changes introduced in this pull request:

  • Implemented eth event filter rpc and added test against lotus
| RPC Method                      | Forest | Lotus |
|---------------------------------|--------|-------|
| eth_newBlockFilter              | Valid  | Valid |
| eth_newFilter                   | Valid  | Valid |
| eth_newPendingTransactionFilter | Valid  | Valid |
| eth_uninstallFilter             | Valid  | Valid |

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@sudo-shashank sudo-shashank changed the title Implement Eth Event Filters Implement Eth Event Filter API's Aug 6, 2024
@LesnyRumcajs
Copy link
Member

@sudo-shashank can we split it into smaller PRs with every method handled separately? It will be easier to review and outstanding comments in one issue wouldn't block another. It's also a good practice to try to limit the PR size (if possible).

@sudo-shashank
Copy link
Contributor Author

@sudo-shashank can we split it into smaller PRs with every method handled separately? It will be easier to review and outstanding comments in one issue wouldn't block another. It's also a good practice to try to limit the PR size (if possible).

yes sure

@sudo-shashank sudo-shashank deleted the shashank/eth-event-filters branch September 26, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants