feat: add CARv2 support to CarStream #5232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanabi1224
commented
Feb 5, 2025
hanabi1224
commented
Feb 5, 2025
| let reference_car_zst = reference(carv2_car_zst()); | ||
| for cid in car_backed.cids() { | ||
| let expected = reference_car.get(&cid).unwrap().unwrap(); | ||
| let expected2 = reference_car_zst.get(&cid).unwrap().unwrap(); |
There was a problem hiding this comment.
These reference calls cover CarStream decoding
hanabi1224
force-pushed
the
hm/car-v2-stream
branch
from
141358d to
5fa7c6c
Compare
hanabi1224
requested review from
LesnyRumcajs and
elmattic
and removed request for
a team
LesnyRumcajs
requested review from
lemmih
and removed request for
LesnyRumcajs
|
Designating @lemmih for the review as the |
lemmih
approved these changes
Feb 7, 2025
elmattic
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Note: butterflynet check succeeded on this branch: https://github.com/ChainSafe/forest/actions/runs/13177200167/job/36779198067
Reference issue to close (if applicable)
Closes #5228
Other information and links
Change checklist