Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop support for old forest versions #5236

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Feb 5, 2025

Summary of changes

Changes introduced in this pull request:

  • The version 0.12.0 is from 2023, which is ages in our world, so there's no point in supporting it anymore. Moved the pole to July 2024.
  • Removed workarounds we had for 0.12.0 and related migrations.
  • Removed a redundant car_db migration test.
  • Revamped the existing failing migration test, given we no longer have failing migrations (I guess the only existing one is missing some assertions...) at the migration phase.
  • This decreases the duration of the DB migration job.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs force-pushed the drop-support-old-forest branch from 359f309 to 5e3fd21 Compare February 5, 2025 11:01
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review February 5, 2025 11:07
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner February 5, 2025 11:07
@LesnyRumcajs LesnyRumcajs requested review from lemmih and elmattic and removed request for a team February 5, 2025 11:08
@LesnyRumcajs LesnyRumcajs marked this pull request as draft February 5, 2025 11:16
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review February 5, 2025 11:28
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Feb 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2025
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 5112927 Feb 5, 2025
42 checks passed
@LesnyRumcajs LesnyRumcajs deleted the drop-support-old-forest branch February 5, 2025 14:19
akaladarshi pushed a commit to akaladarshi/forest that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants