Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): more healthcheck subcommands #5244

Merged
merged 3 commits into from
Feb 6, 2025
Merged

feat(cli): more healthcheck subcommands #5244

merged 3 commits into from
Feb 6, 2025

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Feb 6, 2025 •
edited
Loading

Summary of changes

Currently, we have 3 health check endpoints, namely, readyz, livez and healthz but only 1 CLI command forest-cli healthcheck ready. This PR extends the CLI subcommand to support all 3 endpoints

Changes introduced in this pull request:

  • impl forest-cli healthcheck live
  • impl forest-cli healthcheck healthy

Reference issue to close (if applicable)

Closes #5246

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

hanabi1224
hanabi1224 commented Feb 6, 2025
View reviewed changes
documentation/src/offline-forest.md
@@ -9,7 +9,9 @@ chain's archive state without syncing, and various testing scenarios.
```bash
forest-tool api serve --help
```

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in this file come from make fmt

@hanabi1224 hanabi1224 marked this pull request as ready for review February 6, 2025 04:16
@hanabi1224 hanabi1224 requested a review from a team as a code owner February 6, 2025 04:16
@hanabi1224 hanabi1224 requested review from lemmih, sudo-shashank and LesnyRumcajs and removed request for a team February 6, 2025 04:16
LesnyRumcajs
LesnyRumcajs approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any manual curl checks we do in our tests that could be replaced by this?

@hanabi1224
Copy link
Contributor Author

hanabi1224 commented Feb 6, 2025 •
edited
Loading

Are there any manual curl checks we do in our tests that could be replaced by this?

@LesnyRumcajs Will check and fix in a subsequent PR.

Edit: did not find one

@hanabi1224 hanabi1224 added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 2562773 Feb 6, 2025
42 checks passed
@hanabi1224 hanabi1224 deleted the hm/more-healthcheck-subcommands branch February 6, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih approved these changes

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank sudo-shashank is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend forest-cli healthcheck to support all healthcheck endpoints
3 participants
@hanabi1224 @lemmih @LesnyRumcajs