Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: nix flake #5267

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

ci: nix flake #5267

wants to merge 18 commits into from

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Feb 11, 2025

Summary of changes

Changes introduced in this pull request:

  • Add nix flake for building Forest. This is similar to a Dockerfile, but completely deterministic.

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih
Copy link
Contributor Author

lemmih commented Feb 11, 2025

I'll configure a github workflow in a separate PR. Right now, we do not have any nix caching, and building Forest from scratch takes a while.

@lemmih lemmih marked this pull request as ready for review February 11, 2025 09:31
@lemmih lemmih requested a review from a team as a code owner February 11, 2025 09:31
@lemmih lemmih requested review from elmattic and sudo-shashank and removed request for a team February 11, 2025 09:31
flake.nix Outdated Show resolved Hide resolved
lemmih/nix-flake # Your branch is up to date with 'origin/lemmih/nix-flake'. # # Changes to be committed: # modified:
docs/docs/users/getting_started/install.md # # Untracked files: # PROJECTS.md # PROJECTS.md.save # config.toml #
forest_snapshot_calibnet_2025-02-10_height_2395416.forest.car.zst # log.txt # result # scripts/devnet-curio/data/ #
@@ -0,0 +1,29 @@
name: nix
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: nix
name: nix
# Cancel workflow if there is a new change to the branch.
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lemmih what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update PR in a bit.

@lemmih lemmih marked this pull request as draft February 19, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants