Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): add retry to resolve_libp2p_dnsaddr_test #5268

Merged
merged 7 commits into from
Feb 14, 2025

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Feb 11, 2025

Summary of changes

Changes introduced in this pull request:

  • add retry to resolve_libp2p_dnsaddr_test to avoid flakyness

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review February 11, 2025 12:17
@hanabi1224 hanabi1224 requested a review from a team as a code owner February 11, 2025 12:17
@hanabi1224 hanabi1224 requested review from lemmih and LesnyRumcajs and removed request for a team February 11, 2025 12:17
@hanabi1224 hanabi1224 enabled auto-merge February 11, 2025 14:48
@hanabi1224 hanabi1224 added this pull request to the merge queue Feb 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 11, 2025
@hanabi1224 hanabi1224 enabled auto-merge February 11, 2025 15:13
@hanabi1224 hanabi1224 added this pull request to the merge queue Feb 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 14, 2025
@hanabi1224 hanabi1224 added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit b52e6e1 Feb 14, 2025
35 checks passed
@hanabi1224 hanabi1224 deleted the hm/add-retry-to-resolve_libp2p_dnsaddr_test branch February 14, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants