Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): speed up make test-release #5269

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Feb 11, 2025

Summary of changes

RPC snapshot test is disabled for dev profile due to its flakyness so it's better to re-enable make test-release for PRs

Changes introduced in this pull request:

  • speed up make test-release by using --cargo-profile quick

https://github.com/ChainSafe/forest/actions/runs/13168876489/job/36755252660#step:7:1695

# previously
  Finished `release` profile [optimized] target(s) in 27m 46s

https://github.com/ChainSafe/forest/actions/runs/13262719208/job/37022779822?pr=5269#step:7:1705

# now
  Finished `quick` profile [optimized] target(s) in 13m 54s

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review February 11, 2025 12:46
@hanabi1224 hanabi1224 requested a review from a team as a code owner February 11, 2025 12:46
@hanabi1224 hanabi1224 requested review from elmattic and sudo-shashank and removed request for a team February 11, 2025 12:46
@hanabi1224 hanabi1224 enabled auto-merge February 11, 2025 14:01
@hanabi1224 hanabi1224 added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit 769e74f Feb 11, 2025
37 checks passed
@hanabi1224 hanabi1224 deleted the hm/speed-up-make-test-release branch February 11, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants