Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: correct CNA method names 4/4 #5291

Merged
merged 2 commits into from
Feb 13, 2025
Merged

chore: correct CNA method names 4/4 #5291

merged 2 commits into from
Feb 13, 2025

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Feb 13, 2025 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes #5282

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih marked this pull request as ready for review February 13, 2025 13:41
@lemmih lemmih requested a review from a team as a code owner February 13, 2025 13:41
@lemmih lemmih requested review from LesnyRumcajs and sudo-shashank and removed request for a team February 13, 2025 13:41
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit 2222d41 Feb 13, 2025
35 checks passed
@LesnyRumcajs LesnyRumcajs deleted the lemmih/verify-common-node-parameters branch February 13, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanabi1224 hanabi1224 hanabi1224 approved these changes

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@sudo-shashank sudo-shashank Awaiting requested review from sudo-shashank sudo-shashank is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Verify and adjust common node API parameter names 4/4
3 participants
@lemmih @hanabi1224 @LesnyRumcajs