wip

dot/sync/chain_sync.go

@@ -210,9 +210,6 @@ func (cs *chainSync) start() {
 	cs.wg.Add(1)
 	go cs.pendingBlocks.run(cs.finalisedCh, cs.stopCh, &cs.wg)
 
-	// Is this the right number?
-	// Maybe use wait group here?
-	//cs.requestQueueCh = make(chan requestData, maxRequestsAllowed)
 	cs.wg.Add(1)
 	go cs.startRequestQueue(&cs.wg)
 
@@ -227,7 +224,6 @@ func (cs *chainSync) stop() error {
 	}
 
 	close(cs.stopCh)
-	//close(cs.requestQueueCh) //Do i need this?
 	allStopCh := make(chan struct{})
 	go func() {
 		defer close(allStopCh)

dot/sync/worker_pool.go

@@ -157,8 +157,8 @@ func (s *syncWorkerPool) submitRequest(request *network.BlockRequestMessage,
 	// request it and sent through its queue otherwise send
 	// the request in the general queue where all worker are
 	// listening on
-	s.mtx.Lock()
-	defer s.mtx.Unlock()
+	s.mtx.RLock()
+	defer s.mtx.RUnlock()
 
 	if who != nil {
 		syncWorker := s.workers[*who]
@@ -187,8 +187,8 @@ func (s *syncWorkerPool) submitRequest(request *network.BlockRequestMessage,
 func (s *syncWorkerPool) submitRequests(requests []*network.BlockRequestMessage) (resultCh chan *syncTaskResult) {
 	resultCh = make(chan *syncTaskResult, maxRequestsAllowed+1)
 
-	s.mtx.Lock()
-	defer s.mtx.Unlock()
+	s.mtx.RLock()
+	defer s.mtx.RUnlock()
 
 	allWorkers := maps.Values(s.workers)
 	for idx, request := range requests {
@@ -218,8 +218,8 @@ func (s *syncWorkerPool) ignorePeerAsWorker(who peer.ID) {
 
 // totalWorkers only returns available or busy workers
 func (s *syncWorkerPool) totalWorkers() (total uint) {
-	s.mtx.Lock()
-	defer s.mtx.Unlock()
+	s.mtx.RLock()
+	defer s.mtx.RUnlock()
 
 	for range s.workers {
 		total++

lib/babe/verify.go

@@ -411,8 +411,6 @@ func (b *verifier) verifyBlockEquivocation(header *types.Header) (bool, error) {
 		return false, nil
 	}
 
-	logger.Warnf("%v", equivocationProof)
-
 	err = b.submitAndReportEquivocation(equivocationProof)
 	if err != nil {
 		return false, fmt.Errorf("submiting equivocation: %w", err)

lib/runtime/wazero/instance.go

@@ -605,8 +605,6 @@ func (in *Instance) BabeGenerateKeyOwnershipProof(slot uint64, authorityID [32]b
 func (in *Instance) BabeSubmitReportEquivocationUnsignedExtrinsic(
 	equivocationProof types.BabeEquivocationProof, keyOwnershipProof types.OpaqueKeyOwnershipProof,
 ) error {
-
-	logger.Warnf("SUBMITTING EQUIVOCATION")
 	buffer := bytes.NewBuffer(nil)
 	encoder := scale.NewEncoder(buffer)
 	err := encoder.Encode(equivocationProof)