chore: update Golang to 1.23 on feat/parachain branch (#4391)

.github/workflows/build.yml

@@ -32,7 +32,7 @@ jobs:
     steps:
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.21"
+          go-version: "1.23.2"
           stable: true
           check-latest: true
 
@@ -67,7 +67,7 @@ jobs:
     steps:
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.21"
+          go-version: "1.23.2"
           stable: true
           check-latest: true
 

.github/workflows/checks.yml

@@ -25,7 +25,7 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.21"
+          go-version: "1.23.2"
           stable: true
           check-latest: true
 

.github/workflows/copyright.yml

@@ -23,7 +23,7 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.21"
+          go-version: "1.23.2"
           stable: true
           check-latest: true
 

.github/workflows/devnet.yml

@@ -17,7 +17,7 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.21"
+          go-version: "1.23.2"
           stable: true
           check-latest: true
 

.github/workflows/fuzz.yml

@@ -14,7 +14,7 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.21"
+          go-version: "1.23.2"
           stable: true
           check-latest: true
 

.github/workflows/integration-tests.yml

@@ -45,7 +45,7 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.21"
+          go-version: "1.23.2"
           stable: true
           check-latest: true
 

.github/workflows/mocks.yml

@@ -22,7 +22,7 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.21"
+          go-version: "1.23.2"
           stable: true
           check-latest: true
 

.github/workflows/unit-tests.yml

@@ -29,7 +29,7 @@ jobs:
 
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.21"
+          go-version: "1.23.2"
           stable: true
           check-latest: true
 

.github/workflows/zombienet.yml

@@ -9,7 +9,7 @@ jobs:
     steps:
       - uses: actions/setup-go@v5
         with:
-          go-version: "1.21"
+          go-version: "1.23.2"
           stable: true
           check-latest: true
 

.golangci.yml

@@ -6,14 +6,12 @@ run:
   build-tags:
     - integration
 
-  skip-files:
-    - .*mock_.*\.go
-    - .*mocks\/.*\.go
-
 linters-settings:
   govet:
     # report about shadowed variables
-    check-shadowing: true
+    shadow: true
+    excludes:
+      - printf
 
   revive:
     severity: warning
@@ -33,6 +31,17 @@ linters-settings:
       - map
       - chan
 
+  gosec:
+    excludes:
+      - G115
+      - G301
+      - G306
+
+  gosimple:
+    excludes:
+      - S1009
+
+
   misspell:
     locale: UK
     ignore-words:
@@ -41,12 +50,12 @@ linters-settings:
       - finalized
       - finalize
       - initialize
+      - color
 
 linters:
   enable:
     - bodyclose
     - errcheck
-    - exportloopref
     - goconst
     - gocyclo
     - gofmt
@@ -68,8 +77,13 @@ linters:
     - unparam
     - usestdlibvars
     - unused
+  disable:
+    - typecheck
 
 issues:
+  exclude-files:
+    - .*mock_.*\.go
+    - .*mocks\/.*\.go
   exclude-rules:
     - path: _test\.go
       linters:
@@ -95,6 +109,14 @@ issues:
       linters:
         - govet
 
+    - text: 'printf: non-constant format*'
+      linters:
+        - govet
+
+    - text: 'return both a `nil` error and an invalid value*'
+      linters:
+        - nilnil
+
     - linters:
         - revive
       text: "package comment should be of the form"

Dockerfile

@@ -1,5 +1,5 @@
 ARG DEBIAN_VERSION=bullseye-slim
-ARG GO_VERSION=1.21.1-bullseye
+ARG GO_VERSION=1.23.2-bullseye
 
 FROM golang:${GO_VERSION} AS builder
 

Dockerfile.staging

@@ -1,4 +1,4 @@
-FROM golang:1.22
+FROM golang:1.23
 
 ARG chain="polkadot"
 ARG basepath="~/.local/share/gossamer"

Makefile

@@ -20,7 +20,7 @@ help: Makefile
 
 .PHONY: lint
 lint:
-	go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.54
+	go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.62
 	golangci-lint run
 
 clean:

devnet/alice.Dockerfile

@@ -1,7 +1,7 @@
 # Copyright 2021 ChainSafe Systems (ON)
 # SPDX-License-Identifier: LGPL-3.0-only
 
-FROM golang:1.20
+FROM golang:1.23
 
 ARG DD_API_KEY=somekey
 ARG CHAIN=westend-local

devnet/bob.Dockerfile

@@ -1,7 +1,7 @@
 # Copyright 2021 ChainSafe Systems (ON)
 # SPDX-License-Identifier: LGPL-3.0-only
 
-FROM golang:1.20
+FROM golang:1.23
 
 ARG DD_API_KEY=somekey
 ARG CHAIN=westend-local

devnet/substrate_alice.Dockerfile

@@ -3,7 +3,7 @@
 
 ARG POLKADOT_VERSION=v0.9.37
 
-FROM golang:1.20 as openmetrics
+FROM golang:1.23 as openmetrics
 ARG METRICS_NAMESPACE=substrate.local.devnet
 
 WORKDIR /devnet

devnet/substrate_bob.Dockerfile

@@ -3,7 +3,7 @@
 
 ARG POLKADOT_VERSION=v0.9.37
 
-FROM golang:1.20 as openmetrics
+FROM golang:1.23 as openmetrics
 
 ARG METRICS_NAMESPACE=substrate.local.devnet
 

dot/parachain/backing/per_relay_parent_state.go

@@ -362,7 +362,7 @@ func (rpState *perRelayParentState) validateAndMakeAvailable(
 		bgValidationResult = backgroundValidationResult{
 			outputs:   nil,
 			candidate: &candidateReceipt,
-			err:       fmt.Errorf(validationResultRes.Data.Invalid.Error()),
+			err:       validationResultRes.Data.Invalid,
 		}
 	}
 

go.mod

@@ -200,7 +200,9 @@ require (
 	lukechampine.com/blake3 v1.2.1 // indirect
 )
 
-go 1.21
+go 1.23
+
+toolchain go1.23.2
 
 replace github.com/tetratelabs/wazero => github.com/ChainSafe/wazero v0.0.0-20240319130522-78b21a59bd5f
 

internal/log/level.go

@@ -9,7 +9,7 @@ import (
 	"strconv"
 	"strings"
 
-	"github.com/fatih/color" //nolint:misspell
+	"github.com/fatih/color"
 )
 
 // Level is the level of the logger.

internal/log/log.go

@@ -9,7 +9,7 @@ import (
 	"strings"
 	"time"
 
-	"github.com/fatih/color" //nolint:misspell
+	"github.com/fatih/color"
 )
 
 func (l *Logger) log(logLevel Level, s string, args ...interface{}) {

lib/blocktree/node.go

@@ -112,7 +112,7 @@ func (n *node) getLeaves(leaves []*node) []*node {
 		leaves = []*node{}
 	}
 
-	if n.children == nil || len(n.children) == 0 {
+	if len(n.children) == 0 {
 		leaves = append(leaves, n)
 	}
 

lib/runtime/constants.go

@@ -87,7 +87,7 @@ const (
 	// ParachainHostValidationCodeByHash returns parachain host's validation code by hash
 	ParachainHostValidationCodeByHash = "ParachainHost_validation_code_by_hash"
 	// ParachainHostValidators is the runtime API call ParachainHost_validators
-	ParachainHostValidators = "ParachainHost_validators" //nolint
+	ParachainHostValidators = "ParachainHost_validators"
 	// ParachainHostValidatorGroups is the runtime API call ParachainHost_validator_groups
 	ParachainHostValidatorGroups = "ParachainHost_validator_groups"
 	// ParachainHostAvailabilityCores is the runtime API call ParachainHost_availability_cores

pkg/scale/decode_test.go

@@ -307,7 +307,7 @@ func Test_unmarshal_optionality_nil_case(t *testing.T) {
 
 		temp := reflect.New(reflect.TypeOf(t.in))
 		// create a new pointer to type of temp
-		tempv := reflect.New(reflect.PtrTo(temp.Type()).Elem())
+		tempv := reflect.New(reflect.PointerTo(temp.Type()).Elem())
 		// set zero value to elem of **temp so that is nil
 		tempv.Elem().Set(reflect.Zero(tempv.Elem().Type()))
 		// set test.in to *temp

pkg/scale/encode_test.go

@@ -1222,7 +1222,7 @@ func Test_marshal_optionality_nil_cases(t *testing.T) {
 		// create a new pointer to new zero value of t.in
 		temp := reflect.New(reflect.TypeOf(t.in))
 		// create a new pointer to type of temp
-		tempv := reflect.New(reflect.PtrTo(temp.Type()).Elem())
+		tempv := reflect.New(reflect.PointerTo(temp.Type()).Elem())
 		// set zero value to elem of **temp so that is nil
 		tempv.Elem().Set(reflect.Zero(tempv.Elem().Type()))
 		// set test.in to *temp

pkg/trie/triedb/node.go

@@ -156,7 +156,7 @@ func newNodeFromEncoded(nodeHash common.Hash, data []byte, storage NodeStorage)
 				}
 				return newChild, nil
 			}
-			return nil, nil //nolint:nilnil
+			return nil, nil
 		}
 
 		children := [codec.ChildrenCapacity]NodeHandle{}