-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client(consensus/grandpa): implement grandpaDb and environment types #3383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimjbrettj
requested review from
edwardmack,
timwu20,
EclesioMeloJunior,
kishansagathiya,
dimartiro and
kanishkatn
as code owners
July 12, 2023 20:27
EclesioMeloJunior
requested changes
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The keys and values are always bytes, I see that you are receiving strings, what I would suggest is to:
type databaseKeyValue [2][]byte
type AuxStore interface {
Insert(toInsert []databaseKeyValue, toDelete [][]byte)
Get(key []byte) []byte
}
EclesioMeloJunior
requested changes
Jul 13, 2023
16 tasks
jimjbrettj
changed the title
client(consensus/grandpa): add database interface
client(consensus/grandpa): implement grandpaDb and environment types
Aug 2, 2023
jimjbrettj
force-pushed
the
jimmy/auxDbInterface
branch
from
August 8, 2023 17:48
48e8752
to
8e248c6
Compare
jimjbrettj
force-pushed
the
jimmy/auxDbInterface
branch
2 times, most recently
from
August 8, 2023 20:32
93a7265
to
04441f2
Compare
timwu20
reviewed
Aug 9, 2023
3 tasks
timwu20
requested changes
Aug 15, 2023
timwu20
force-pushed
the
jimmy/authorityChangeTree
branch
from
August 16, 2023 16:53
a06ea09
to
293683a
Compare
jimjbrettj
force-pushed
the
jimmy/auxDbInterface
branch
from
August 16, 2023 20:48
66a31fa
to
fd96db7
Compare
EclesioMeloJunior
requested changes
Aug 22, 2023
jimjbrettj
force-pushed
the
jimmy/authorityChangeTree
branch
from
September 6, 2023 20:58
293683a
to
bd5ec29
Compare
jimjbrettj
force-pushed
the
jimmy/auxDbInterface
branch
from
September 6, 2023 20:59
5bea8bf
to
97fdeab
Compare
timwu20
requested changes
Sep 10, 2023
jimjbrettj
force-pushed
the
jimmy/auxDbInterface
branch
from
September 11, 2023 21:16
97fdeab
to
2f30b62
Compare
jimjbrettj
force-pushed
the
jimmy/auxDbInterface
branch
from
September 28, 2023 19:51
df18611
to
09d310a
Compare
timwu20
reviewed
Oct 5, 2023
jimjbrettj
force-pushed
the
jimmy/auxDbInterface
branch
from
October 10, 2023 17:49
20bef8a
to
db5219f
Compare
timwu20
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
timwu20
pushed a commit
that referenced
this pull request
Dec 5, 2023
timwu20
pushed a commit
that referenced
this pull request
Apr 18, 2024
timwu20
pushed a commit
that referenced
this pull request
Apr 19, 2024
timwu20
pushed a commit
that referenced
this pull request
Apr 19, 2024
timwu20
pushed a commit
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
go test -tags integration github.com/ChainSafe/gossamer
Issues
Primary Reviewer
@EclesioMeloJunior