-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parachain/availabilitystore): implement database access functions for availability store subsystem #3640
Conversation
Right now, if you try to build this directly it won't
You will have to build the erasure lib first
and then call Let's add this into our ci workflows so that CI dont fail. Right now, this is what is causing CI fails in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of structs, methods in this package will likely not get used outside. Unless we have to scale encode or decode them, let's unexport them. I have pointed only at a few places, but there are many other places as well.
d12bc14
to
4f69f58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are files that are being autogenerated inside lib/erasure/rustlib
. Put them in .gitignore.
My bad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…s for availability store subsystem (#3640) Co-authored-by: Kishan Sagathiya <[email protected]>
…s for availability store subsystem (#3640) Co-authored-by: Kishan Sagathiya <[email protected]>
…s for availability store subsystem (#3640) Co-authored-by: Kishan Sagathiya <[email protected]>
…s for availability store subsystem (#3640) Co-authored-by: Kishan Sagathiya <[email protected]>
…s for availability store subsystem (#3640) Co-authored-by: Kishan Sagathiya <[email protected]>
…s for availability store subsystem (#3640) Co-authored-by: Kishan Sagathiya <[email protected]>
Changes
This PR introduces code for handle database access for the availability store subsystem to enable write, read and delete of data to persistent storage.
Tests
go test github.com/ChainSafe/gossamer/dot/parachain/availability-store
Issues
closes: #3628
Primary Reviewer
@kishansagathiya @axaysagathiya