Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(pkg/trie): Create standalone trie package #3658

Merged
merged 43 commits into from
Feb 21, 2024
Merged

chore(pkg/trie): Create standalone trie package #3658

merged 43 commits into from
Feb 21, 2024

Conversation

dimartiro
Copy link
Contributor

@dimartiro dimartiro commented Jan 3, 2024 •
edited
Loading

Changes

Create the standalone /pkg/trie

TODO

  • Move /lib/trie to /pkg/trie
  • Move /internal/trie to /pkt/trie
  • Update imports and tests

Tests

make test

Issues

closes #3757

Primary Reviewer

@timwu20

@codecov Codecov
Copy link

codecov bot commented Jan 8, 2024 •
edited
Loading

Codecov Report

Attention: 112 lines in your changes are missing coverage. Please review.

Comparison is base (d1ca7aa) 50.51% compared to head (f2617aa) 50.19%.
Report is 13 commits behind head on development.

❗ Current head f2617aa differs from pull request most recent head e351c39. Consider uploading reports for the commit e351c39 to get more accurate results

Additional details and impacted files 
@@               Coverage Diff               @@
##           development    #3658      +/-   ##
===============================================
- Coverage        50.51%   50.19%   -0.32%     
===============================================
  Files              230      231       +1     
  Lines            29006    28782     -224     
===============================================
- Hits             14653    14448     -205     
+ Misses           12856    12809      -47     
- Partials          1497     1525      +28

dimartiro added 15 commits January 8, 2024 12:13
@dimartiro
feat(pkg/trie): Add license
4188cec
@dimartiro
Merge branch 'development' of https://github.com/ChainSafe/gossamer i…
c8c277f 
…nto diego/pkg/trie
@dimartiro
feat(pkg/trie): fixes and implements lookup and cache
f597bf8
@dimartiro
feat(pkg/trie): Implements remove inspector
1dd1f13
@dimartiro
Fixes and insert inspector
0fd4c49
@dimartiro
feat(pkg/trie): Implements fix nodes method
811638d
@dimartiro
feat(pkg/trie): NibbleSlice tests
490185f
@dimartiro
chore(pkg/trie): Add missing licenses
869f9b1
@dimartiro
Merge branch 'development' of https://github.com/ChainSafe/gossamer i…
09a119d 
…nto diego/pkg/trie
@dimartiro
Merge branch 'development' of https://github.com/ChainSafe/gossamer i…
4b7fc53 
…nto diego/pkg/trie
@dimartiro
feat(pkg/trie): Implements keccak hasher
d57528c
@dimartiro
refa(pkg/trie): Simplify generics
c292d8a
@dimartiro
feat(pkg/trie): Implements memoryDB
b18dc65
@dimartiro
fix(pkg/trie): fixes and add missing license
3f5d116
@dimartiro
Merge branch 'development' of https://github.com/ChainSafe/gossamer i…
f2617aa 
…nto diego/pkg/trie
@dimartiro dimartiro added C-complex Complex changes across multiple modules. Possibly will require additional research. T-enhancement this issue/pr covers improvement of existing functionality. labels Jan 15, 2024
This was referenced Jan 16, 2024
Closed
Closed
@dimartiro dimartiro changed the title feat(pkg/trie): Parity trie crate translation feat(pkg/trie): Parity trie crate translation [WIP] Jan 17, 2024
@dimartiro dimartiro changed the title feat(pkg/trie): Parity trie crate translation [WIP] chore(pkg/trie): Create standalone trie package Feb 14, 2024
@dimartiro dimartiro marked this pull request as ready for review February 14, 2024 15:22
@dimartiro dimartiro added C-simple Minor changes changes, no additional research needed. Good first issue/review. and removed C-complex Complex changes across multiple modules. Possibly will require additional research. Feature-branch labels Feb 14, 2024
@dimartiro dimartiro merged commit 200ca4b into development Feb 21, 2024
23 checks passed
@dimartiro dimartiro deleted the diego/pkg/trie branch February 21, 2024 14:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

🎉 This PR is included in version 0.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

timwu20 pushed a commit that referenced this pull request Apr 19, 2024
@dimartiro @timwu20
chore(pkg/trie): Create standalone trie package (#3658)
3f21724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimjbrettj jimjbrettj jimjbrettj approved these changes

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@timwu20 timwu20 timwu20 approved these changes

@edwardmack edwardmack Awaiting requested review from edwardmack

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya

@axaysagathiya axaysagathiya Awaiting requested review from axaysagathiya

Assignees
No one assigned
Labels
C-simple Minor changes changes, no additional research needed. Good first issue/review. T-enhancement this issue/pr covers improvement of existing functionality.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

trie: Create standalone pkg/trie
5 participants
@dimartiro @timwu20 @EclesioMeloJunior @jimjbrettj @P1sar