Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sync): tip sync can follow chain and finalize blocks #3765

Merged
merged 10 commits into from
Mar 7, 2024
Merged

fix(sync): tip sync can follow chain and finalize blocks #3765

merged 10 commits into from
Mar 7, 2024

Conversation

jimjbrettj
Copy link
Contributor

Changes

  • The gossamer node was built to only handle neighbor messages when we are an authority. However if we do not handle a neighbor message when we are not an authority then other nodes on the network will not send us messages. This meant that gossamer was not receiving commit messages and thus not tracking the finalized chain.
  • Clean up some logs

Tests

  • Sync a paseo node and verify that we can transition to tip mode and continue processing the chain
  • If you would like, spin up local devnet to test
go test -tags integration ./dot/sync

Issues

Closes #3705

Primary Reviewer

@EclesioMeloJunior

@jimjbrettj jimjbrettj changed the title fix(sync): tip sync follow chain and finalize blocks fix(sync): tip sync can follow chain and finalize blocks Feb 16, 2024
EclesioMeloJunior
EclesioMeloJunior requested changes Feb 19, 2024
View reviewed changes
lib/grandpa/message_handler.go Outdated Show resolved Hide resolved
@P1sar P1sar added this to the Release v0.9.0 milestone Feb 21, 2024
EclesioMeloJunior
EclesioMeloJunior approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@EclesioMeloJunior EclesioMeloJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny suggestion regards the names

dot/state/block.go Outdated Show resolved Hide resolved
lib/grandpa/state.go Outdated Show resolved Hide resolved
@P1sar P1sar removed this from the Release v0.9.0 milestone Feb 28, 2024
timwu20
timwu20 reviewed Mar 5, 2024
View reviewed changes
dot/sync/worker_pool.go Outdated Show resolved Hide resolved
lib/grandpa/message_handler.go Outdated Show resolved Hide resolved
@jimjbrettj jimjbrettj requested a review from timwu20 March 5, 2024 17:46
timwu20
timwu20 approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@timwu20 timwu20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change

dot/sync/worker_pool.go Outdated Show resolved Hide resolved
@jimjbrettj jimjbrettj force-pushed the jimmy/fixTipSync branch 2 times, most recently from c673744 to 3272d80 Compare March 7, 2024 16:04
@jimjbrettj jimjbrettj merged commit 20aa004 into development Mar 7, 2024
22 of 23 checks passed
@jimjbrettj jimjbrettj deleted the jimmy/fixTipSync branch March 7, 2024 16:53
dimartiro pushed a commit that referenced this pull request Mar 11, 2024
@jimjbrettj @dimartiro
fix(sync): tip sync can follow chain and finalize blocks (#3765)
6c76e59
timwu20 pushed a commit that referenced this pull request Apr 19, 2024
@jimjbrettj @timwu20
fix(sync): tip sync can follow chain and finalize blocks (#3765)
c4347bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timwu20 timwu20 timwu20 approved these changes

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@edwardmack edwardmack Awaiting requested review from edwardmack

@kishansagathiya kishansagathiya Awaiting requested review from kishansagathiya

@dimartiro dimartiro Awaiting requested review from dimartiro

@axaysagathiya axaysagathiya Awaiting requested review from axaysagathiya

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gossamer is not changing to tip mode properly
4 participants
@jimjbrettj @timwu20 @EclesioMeloJunior @P1sar