Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prospective-parachains) handle GetMinimumRelayParents signal #4326

Conversation

DanielDDHM
Copy link

Changes

Parachain Validity and Dispute Handling: Improvements in how parachain candidates are attested and how dispute statements are handled.
Answer Minimum Relay Parents Request: A new function to retrieve and process relay parent data for parachains.
Enhanced Encoding: Updates to the encoding functions for improved compatibility with Polkadot’s inherent data requirements.

Tests

Unit Tests: Core logic is tested in isolation using testify for assertions

go test -tags integration github.com/ChainSafe/gossamer

Issues

4312

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2024

CLA assistant check
All committers have signed the CLA.

@EclesioMeloJunior
Copy link
Member

Hey @DanielDDHM, the issue #4312 refers to a function that should be implemented as part of the prospective-parachains subsystem, and it should be addressed after merging PR #4325. So I will close it since it is not implemented correctly.

For context, the function answer_minimum_relay_parents_request is a routine that is executed when the ProspectiveParachains subsystem receive a message ProspectiveParachainsMessage::GetMinimumRelayParents from CandidateBacking subsystem, and here you have introduced the function in the wrong place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants