-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: check auth changes before processing block #4336
Conversation
e9a96e7
to
1e52fad
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #4336 +/- ##
===============================================
+ Coverage 50.51% 53.14% +2.62%
===============================================
Files 230 299 +69
Lines 29006 38244 +9238
===============================================
+ Hits 14653 20323 +5670
- Misses 12856 15988 +3132
- Partials 1497 1933 +436
|
18c2431
to
720d272
Compare
c0750dd
to
0167519
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dimartiro I was too late to check on Grafana how far the node has synced and my local node hasn't gotten to the problematic block yet. But based on your screenshot on the issue and the code changes, I believe that the issue is fixed.
f841e2c
to
2d8968e
Compare
2c861aa
to
248bfab
Compare
The latest deployment stalled at block #1491033. Apart from lots of networking errors, I found this in the logs:
|
Lots of changes since my approval. Will do another review once the current issue has been addressed.
Yeah, I'm changing the approach and trying with the latest comment from Eclesio |
248bfab
to
507d3a9
Compare
507d3a9
to
0d9111a
Compare
Changes
runtime.DigestItem
This changes will fix 2 issues:
Tests
make test
Issues
closes #4281