Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dot/parachains): implement ReputationAggregator #4401

Conversation

DanielDDHM
Copy link

Changes

implements ReputationAggregator

Tests

Unit Tests: Core logic is tested in isolation using testify for assertions

go test -tags integration github.com/ChainSafe/gossamer

Issues

@DanielDDHM DanielDDHM marked this pull request as ready for review December 10, 2024 19:08
@EclesioMeloJunior EclesioMeloJunior changed the title feat(prospective-parachains): implement ReputationAggregator feat(dot/parachains): implement ReputationAggregator Dec 10, 2024
Copy link
Member

@EclesioMeloJunior EclesioMeloJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, just a small change

dot/parachain/util/util.go Outdated Show resolved Hide resolved
dot/parachain/util/util.go Outdated Show resolved Hide resolved
Copy link
Contributor

@haikoschol haikoschol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also fix the linter issues please.

dot/parachain/util/util.go Outdated Show resolved Hide resolved
dot/parachain/util/util.go Outdated Show resolved Hide resolved
dot/parachain/util/util_test.go Outdated Show resolved Hide resolved
@DanielDDHM
Copy link
Author

Also fix the linter issues please.

@haikoschol adjusted.

@haikoschol
Copy link
Contributor

Also fix the linter issues please.

@haikoschol adjusted.

Two more left:

golangci-lint run
dot/parachain/util/util.go:126: the line is 126 characters long, which exceeds the maximum of 120 characters. (lll)
func (r *ReputationAggregator) Modify(overseerCh chan<- NetworkBridgeTxMessage, peerID peer.ID, rep UnifiedReputationChange) {
dot/parachain/util/util.go:139: the line is 130 characters long, which exceeds the maximum of 120 characters. (lll)
func (r *ReputationAggregator) singleSend(overseerCh chan<- NetworkBridgeTxMessage, peerID peer.ID, rep UnifiedReputationChange) {
make: *** [Makefile:24: lint] Error 1

@DanielDDHM
Copy link
Author

golangci-lint run
dot/parachain/util/util.go:126: the line is 126 characters long, which exceeds the maximum of 120 characters. (lll)
func (r *ReputationAggregator) Modify(overseerCh chan<- NetworkBridgeTxMessage, peerID peer.ID, rep UnifiedReputationChange) {
dot/parachain/util/util.go:139: the line is 130 characters long, which exceeds the maximum of 120 characters. (lll)
func (r *ReputationAggregator) singleSend(overseerCh chan<- NetworkBridgeTxMessage, peerID peer.ID, rep UnifiedReputationChange) {
make: *** [Makefile:24: lint] Error 1

also fixed, thanks

Copy link
Contributor

@haikoschol haikoschol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DanielDDHM thank you very much! 🙏

@haikoschol haikoschol enabled auto-merge (squash) December 11, 2024 09:56
@haikoschol haikoschol merged commit 3f81dd2 into ChainSafe:feat/parachain Dec 11, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants