-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dot/parachains): implement ReputationAggregator #4401
feat(dot/parachains): implement ReputationAggregator #4401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, just a small change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also fix the linter issues please.
@haikoschol adjusted. |
Two more left:
|
also fixed, thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DanielDDHM thank you very much! 🙏
Changes
implements ReputationAggregator
Tests
Unit Tests: Core logic is tested in isolation using testify for assertions
go test -tags integration github.com/ChainSafe/gossamer
Issues
ReputationAggregator
#4345