Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implementing answerProspectiveValidationDataRequest #4516

Open
wants to merge 5 commits into
base: feat/parachain
Choose a base branch
from
Open

feat: implementing answerProspectiveValidationDataRequest #4516

wants to merge 5 commits into from

Conversation

KaioApeles
Copy link

@KaioApeles KaioApeles commented Jan 29, 2025 •
edited
Loading

Changes

Implemented function answerProspectiveValidationDataRequest in prospective-parachains.go file

Tests

go test -timeout 30s -run ^TestAnswerProspectiveValidationDataRequest$ github.com/ChainSafe/gossamer/dot/parachain/prospective-parachains

Issues

Closes #4313

@CLAassistant
Copy link

CLAassistant commented Jan 29, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@KaioApeles KaioApeles marked this pull request as ready for review January 30, 2025 19:58
EclesioMeloJunior
EclesioMeloJunior requested changes Jan 31, 2025
View reviewed changes
Copy link
Member

@EclesioMeloJunior EclesioMeloJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🚀 , just small comments!

dot/parachain/prospective-parachains/messages.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/prospective-parachains.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/prospective-parachains.go Outdated Show resolved Hide resolved
dot/parachain/prospective-parachains/prospective-parachains.go Show resolved Hide resolved
@KaioApeles
Copy link
Author

KaioApeles commented Jan 31, 2025 •
edited
Loading

Thanks for the contribution 🚀 , just small comments!

Appreciate it! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EclesioMeloJunior EclesioMeloJunior EclesioMeloJunior approved these changes

@jimjbrettj jimjbrettj Awaiting requested review from jimjbrettj jimjbrettj is a code owner

@timwu20 timwu20 Awaiting requested review from timwu20 timwu20 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaioApeles @CLAassistant @EclesioMeloJunior