feat(internal/client) GossipEngine implementation with dependency Network and Syncing interfaces
#4572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwu20
force-pushed
the
tim/gossip-engine
branch
from
4d0f119 to
8d9a1bc
Compare
timwu20
force-pushed
the
tim/gossip-engine
branch
from
d40d5fa to
26ec185
Compare
timwu20
force-pushed
the
tim/gossip-engine
branch
from
26ec185 to
ba5deda
Compare
timwu20
changed the title
GossipEngine implementation with dependency Network and Syncing interfaces
timwu20
requested review from
EclesioMeloJunior and
jimjbrettj
as code owners
P1sar
reviewed
Feb 27, 2025
P1sar
reviewed
Feb 27, 2025
P1sar
reviewed
Feb 27, 2025
P1sar
approved these changes
Mar 6, 2025
EclesioMeloJunior
approved these changes
Mar 6, 2025
haikoschol
reviewed
Mar 7, 2025
| } | ||
|
|
||
| // Local implementation of [ValidatorContext]. | ||
| type newtorkContext[H runtime.Hash, Hasher runtime.Hasher[H]] struct { |
There was a problem hiding this comment.
Suggested change
| type newtorkContext[H runtime.Hash, Hasher runtime.Hasher[H]] struct { | |
| type networkContext[H runtime.Hash, Hasher runtime.Hasher[H]] struct { |
| // Requested broadcast to all peers. | ||
| MessageIntentForcedBroadcast | ||
| // Periodic rebroadcast of all messages to all peers. | ||
| MessageIntentPeriodicReboradcast |
There was a problem hiding this comment.
Suggested change
| MessageIntentPeriodicReboradcast | |
| MessageIntentPeriodicRebroadcast |
| propagate(notificationService, cg.protocol, messages, intent, cg.peers, cg.validator) | ||
| } | ||
|
|
||
| // Prune old or no longer relevant consensus messages. Provide a predicate for pruning, which returns false when the |
There was a problem hiding this comment.
Is the the comment about providing a predicate is outdated, since the method takes no parameters?
haikoschol
reviewed
Mar 7, 2025
| return r.intersects(RolesFull | RolesAuthority) | ||
| } | ||
|
|
||
| // Does this role represents a client that does not participates in the consensus? |
There was a problem hiding this comment.
Should this be:
Suggested change
| // Does this role represents a client that does not participates in the consensus? | |
| // Does this role represents a client that participates in the consensus? | |
| ```? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
GossipEngineimplementation.service.NetworkPeers,service.NetworkEventStream,sync.SyncEventStream, andservice.NetworkBlockinterfaces.gossip.Networkandgossip.Syncinginterfaces as dependencies forGossipEngine.NetworkandSyncingimplementations.Tests
go test -tags integration github.com/ChainSafe/gossamerIssues
closes #4522