feat(parachain): availability distribution skeleton #4591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haikoschol
requested review from
EclesioMeloJunior,
jimjbrettj and
timwu20
as code owners
haikoschol
force-pushed
the
haiko/availability-distribution/skeleton
branch
from
ddb5300 to
ea3bb31
Compare
| var _ parachaintypes.Subsystem = (*AvailabilityDistribution)(nil) | ||
|
|
||
| type Network interface { | ||
| RegisterRequestHandler(subprotocolID protocol.ID, handler network.RequestHandler) |
There was a problem hiding this comment.
I might be missing something, but why can the subsystem register a handler? I mean, in what specific case the subsystem will register a request handler for a specific network protocol id?
There was a problem hiding this comment.
The availability distribution subsystem is responsible for fetching erasure chunks and PoVs as well as responding to those requests from other nodes.
So on startup the subsystem will register handlers for req_chunk/1 (and/or req_chunk/2) and req_pov/1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces the availability distribution subsystem. It includes a few minor changes to code outside of
dot/parachainand a fix for some tests that was cherry picked fromdevelopment.Tests
go test ./dot/parachain/availability-distributionIssues
#4485